Skip to content

twelve-days: Add parameters to exercise placeholder #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2017
Merged

twelve-days: Add parameters to exercise placeholder #971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b614f07
Add parameters to exercise placeholder for twelve-days
ackerleytng Oct 23, 2017
9e8d883
Rename n to day_number
ackerleytng Oct 24, 2017
aa64dae
Merge branch 'master' into twelve-days-parameters
ilya-khadykin Oct 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions exercises/twelve-days/example.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@
'seventh', 'eighth', 'ninth', 'tenth', 'eleventh', 'twelfth']


def verse(n):
gifts = GIFTS[-n:]
def verse(day_number):
gifts = GIFTS[-day_number:]
if len(gifts) > 1:
gifts[:-1] = [', '.join(gifts[:-1])]
gifts = ', and '.join(gifts)
return 'On the {} day of Christmas my true love gave to me, {}.\n'.format(
ORDINAL[n], gifts)
ORDINAL[day_number], gifts)


def verses(start, end):
Expand Down
4 changes: 2 additions & 2 deletions exercises/twelve-days/twelve_days.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
def verse():
def verse(day_number):
pass


def verses():
def verses(start, end):
pass


Expand Down