-
Notifications
You must be signed in to change notification settings - Fork 542
no-op declare compliance with problem-specifications for any input object change #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ations robot-simulator 2.2.0: Input object (instructions) exercism/problem-specifications#1166 robot-simulator 2.1.0: Input object exercism/problem-specifications#1163 robot-simulator 2.0.0: Object instead of string exercism/problem-specifications#936 exercism/problem-specifications#722
queen-attack 2.1.0: Input object exercism/problem-specifications#1158 queen-attack 2.0.0: Object instead of string exercism/problem-specifications#935 exercism/problem-specifications#721
…pecifications input object exercism/problem-specifications#1114
…ecifications input object exercism/problem-specifications#1064
No--Cargo.toml is the standard location for a version string in Rust; .meta/version or whatever would be an exercism-specific thing. Generally speaking this looks good to me. Once Travis has been placated, feel free to merge. Not sure what precisely has gone wrong there; check-exercises.sh produced no output after 10 minutes. I wouldn't be bothered if we had to have it emit a heartbeat dot or something after every exercise check, if it turns out that it actually needed more than ten minutes to run. Sorry I'm not actually helping more with this, I've started a new job and have far fewer hours per week to give to exercism than I have in the past. |
OK that's done (I just reran), so here it comes. |
Oh, yeah, makes sense, since we add
I accept the apology, because I also don't put in particularly many hours lately. I thought I read somewhere in https://jvns.ca/blog/2014/04/26/i-dont-feel-guilty-about-not-contributing-to-open-source/ that time was a component but turns out I misremembered; the three components were competence, autonomy, and relatedness. But the point I was trying to make was that nobody should feel obligated. |
Otherwise, Travis may assume we're hung if we don't produce output in 10+ minutes. Normally we don't think checking all exercises takes this long, but this prepares for the future and prevents spurious failures in instances when outside circumstances cause slowness. This approach was suggested in response to such a failure in #435 (comment)
In exercism/problem-specifications#996 it was proposed that inputs will be moved to the input object.
It was enacted across all the exercises.
For those exercises for which the input type is the only reason the Rust track is no longer up to date, those exercises are now declared to be up to date.
No attempt was made to update any exercise that was out of date for any other reason. The author has no interest in writing the test generators at this time, nor making any changes by hand.
The up-to-date determination was done in the usual manner (https://github.com/petertseng/exercism-problem-specifications/blob/up-to-date/up-to-date/rust.rb).
All commit contents were generated by the following script.
With the exception of queen-attack and robot-simulator (written by hand), all commits messages were also generated by the following script
Question:
exercism/discussions#133 (comment)
So, does this also apply to the version being in Cargo.toml?