Skip to content

IBX-461: Fixed roles with deleted limitations#1781

Merged
lserwatka merged 2 commits into
2.3from
ibx-461-fix-roles-with-deleted-limitations
Jun 17, 2021
Merged

IBX-461: Fixed roles with deleted limitations#1781
lserwatka merged 2 commits into
2.3from
ibx-461-fix-roles-with-deleted-limitations

Conversation

@barw4

@barw4 barw4 commented Jun 16, 2021

Copy link
Copy Markdown
Member
Question Answer
Tickets IBX-461
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Follow up PR of ezsystems/repository-forms#347.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 self-assigned this Jun 16, 2021
@barw4
barw4 requested a review from a team June 16, 2021 13:22

@Steveb-p Steveb-p left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the general solution.

@Steveb-p
Steveb-p requested review from a team and alongosz June 16, 2021 15:23

@tomaszszopinski tomaszszopinski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on Ibexa DXP 3.3.4 & 3.3.4-dev with diff & patch

@lserwatka
lserwatka merged commit 6332d3e into 2.3 Jun 17, 2021
@lserwatka
lserwatka deleted the ibx-461-fix-roles-with-deleted-limitations branch June 17, 2021 10:48
@lserwatka

Copy link
Copy Markdown
Member

You can merge it up

@barw4

barw4 commented Jun 17, 2021

Copy link
Copy Markdown
Member Author

Merged into master: c245fe1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

7 participants