IBX-461: Fixed roles with deleted limitations#347
Merged
Conversation
alongosz
approved these changes
Jun 9, 2021
adamwojs
approved these changes
Jun 14, 2021
Steveb-p
approved these changes
Jun 14, 2021
Steveb-p
left a comment
Steveb-p
left a comment
There was a problem hiding this comment.
LGTM, just a "nitpicky" remark. I see a similar code used elsewhere.
mikadamczyk
approved these changes
Jun 14, 2021
webhdx
approved these changes
Jun 14, 2021
tomaszszopinski
approved these changes
Jun 16, 2021
tomaszszopinski
left a comment
tomaszszopinski
left a comment
There was a problem hiding this comment.
QA approved on eZPlatform 2.5 & v2.5.20 with patch & diff.
Member
|
You can merge it up now |
Member
Author
|
Merged into Follow up PRs need to be created for |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fallbacks have been added to properly handle deleted Limitations, especially Location one.