style(docsearch): add cursor + logo #11032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 88c93f7 |
|
Colour lgtm 🙌 |
fixes facebook#10965 Not completely convinced about the cursor colour, but I couldn't really find a better one, cc @joecritch
Haroenv
force-pushed
the
docs/cursor-logo
branch
from
39fbf9a to
c3f5fe3
Compare
|
I just tweaked the colour a little, made it slightly lighter so that it doesn't clash with the title on the left, and added an indicator to the right in the accent colour
|
|
This looks great, Haroen! Thanks for making these changes. One small request though. Can we make the no-results view look better?
|
|
PS If you rebase, the CI error is fixed now in master |
|
Perfect, didn’t think of the no results view, will fix it tomorrow |
fixes facebook#10965 Not completely convinced about the cursor colour, but I couldn't really find a better one, cc @joecritch
|
Looks like this now @bvaughn |
|
Screenshot looks good. Netlify preview failed to build though so I restarted it. Want to verify visually before merging. 😄 |
bvaughn
approved these changes
Oct 3, 2017
|
Perfect, thanks for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10965
Not completely convinced about the cursor colour, but I couldn't really find a better one, cc @joecritch
Before submitting a pull request, please make sure the following is done:
master.npm test).npm run prettier).npm run lint).npm run flow).