Skip to content

Ensure Algolia attribution is present on search dropdown #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
phrawzty opened this issue Oct 11, 2017 · 4 comments · Fixed by #151
Closed

Ensure Algolia attribution is present on search dropdown #130

phrawzty opened this issue Oct 11, 2017 · 4 comments · Fixed by #151
Labels
difficulty: beginner good first issue type: website

Comments

@phrawzty
Copy link

Hello!

Just wanted to pop in to mention that the Algolia logo in the search dropdown doesn't appear to be visible in Firefox (oddly enough). Screenshot time!

Firefox 56 (OS X):
image

Check that bottom right corner...

Chrome 61 (OS X):
image

I see that our very own @Haroenv touched this topic in facebook/react#11032. Could be a good place to start looking?

For the sake of completeness, I've also looped in @vjeux via email, which isn't a GitHub Issue but oh well! 😉
@Haroenv
Copy link
Contributor

Haroenv commented Oct 11, 2017

Whoops, I didn't test it in FF, it works in Safari though 😃

@renatoselenica
Copy link
Contributor

I am doing some tests on this and it looks like its an svg issue on how firefox detects the svg passed as background img. I am trying to figure it out but do not know enough about svg.

@Haroenv
Copy link
Contributor

Haroenv commented Oct 12, 2017

@renatoselenica, oh good catch! I think we forgot to encode the hash

Haroenv added a commit to Haroenv/reactjs.org that referenced this issue Oct 12, 2017
@Haroenv
fix(algolia): make logo show up on FF
eeedf1c 
Background images in svg need to have the # encoded to show up if the image type is svg+xml;utf8

fixes reactjs#130
@Haroenv Haroenv mentioned this issue Oct 12, 2017
Merged
@phrawzty
Copy link
Author

Fantastic - thanks everybody!

jhonmike pushed a commit to jhonmike/reactjs.org that referenced this issue Jul 1, 2020
@rcantuario @halian-vilela
Translating reference-react-component (reactjs#130)
f40151b 
* translate React API Reference

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

Co-Authored-By: renato-bohler <[email protected]>

* Update content/docs/reference-react.md

* Update content/docs/reference-react.md

* updating reference react-component

* translates error boundaries section in reference-react-component

* translates getDerivedStateFromError section in reference-react-component

* translates componentDidCatch section in reference-react-component

* translates legacy lifecycle methods section in reference-react-component

* translates componentWillMount section in reference-react-component

* translates componentWillReceiveProps section in reference-react-component

* translates componentWillUpdate section in reference-react-component

* translates Other APIs section in reference-react-component

* translates setState section in reference-react-component

* translates forceUpdate section in reference-react-component

* translates defaultProps section in reference-react-component

* translates displayName section in reference-react-component

* translates props section in reference-react-component

* translates state section in reference-react-component

* Continua com o processo de tradução

* translating life cycle methods

* finishing lifecycle methods

* Update content/docs/reference-react-component.md

Co-Authored-By: rcantuario <[email protected]>

* Update content/docs/reference-react-component.md

Co-Authored-By: rcantuario <[email protected]>

* Update content/docs/reference-react-component.md

Co-Authored-By: rcantuario <[email protected]>

* Update content/docs/reference-react-component.md

Co-Authored-By: rcantuario <[email protected]>

* Update content/docs/reference-react-component.md

Alterando conforme sugerido pela @glaucia86

Co-Authored-By: rcantuario <[email protected]>

* Update content/docs/reference-react-component.md

Alterando conforme sugerido pela @glaucia86

Co-Authored-By: rcantuario <[email protected]>

* Update content/docs/reference-react-component.md

Co-Authored-By: rcantuario <[email protected]>

* Update content/docs/reference-react-component.md

Alterando conforme sugerido pela @glaucia86

Co-Authored-By: rcantuario <[email protected]>

* Update content/docs/reference-react-component.md

Co-Authored-By: rcantuario <[email protected]>

* Update content/docs/reference-react-component.md

Co-Authored-By: rcantuario <[email protected]>

* Update content/docs/reference-react-component.md

Co-Authored-By: rcantuario <[email protected]>
BetterZxx pushed a commit to BetterZxx/react.dev that referenced this issue Mar 21, 2023
@QC-L
docs(en): merge reactjs.org into zh-hans(reactjs#130)
bcbe394 
Sync with reactjs.org @ d615c5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: beginner good first issue type: website
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(algolia): make logo show up on FF Haroenv/reactjs.org
4 participants
@bvaughn @phrawzty @Haroenv @renatoselenica