Skip to content

fix(algolia): make logo show up on FF #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Oct 12, 2017

Background images in svg need to have the # encoded to show up if the image type is svg+xml;utf8

fixes #130

Background images in svg need to have the # encoded to show up if the image type is svg+xml;utf8

fixes reactjs#130
@reactjs-bot
Copy link

Deploy preview ready!

Built with commit eeedf1c

https://deploy-preview-151--reactjs.netlify.com

@Haroenv
Copy link
Contributor Author

Haroenv commented Oct 12, 2017

It works in FF for me now

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks 👍

@bvaughn bvaughn merged commit 0748aaf into reactjs:master Oct 16, 2017
@Haroenv Haroenv deleted the fix/algolia-logo-FF branch November 3, 2017 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure Algolia attribution is present on search dropdown
4 participants