Share reconcile transaction in batched updates #1358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Depends on #1362.) |
| var flushBatchedUpdates = ReactPerf.measure( | ||
| 'ReactUpdates', | ||
| 'flushBatchedUpdates', | ||
| function() { | ||
| // Run these in separate functions so the JIT can optimize |
There was a problem hiding this comment.
Very little time is spent in this function; everything that was in subfunctions before, still is.
Should make facebook#1350 better and will also take away any performance hit from facebook#1157. Test Plan: grunt test
| ReactUpdates.ReactReconcileTransaction && batchingStrategy, | ||
| 'ReactUpdates: must inject a reconcile transaction class and batching ' + | ||
| 'strategy' | ||
| ); | ||
| } | ||
|
|
||
| function batchedUpdates(callback, param) { |
There was a problem hiding this comment.
I was going to complain and say that this doesn't really need ReactReconcileTransaction to be injected. And we had a bunch of tests which were failing because they only inject the batching strategy (some flux-related code uses ReactUpdates directly). But then I just made those tests use ReactDefaultInjection instead.
|
I'm sure you figured this out weeks ago but along with this change, ReactART needs to reference |
zpao
added a commit
that referenced
this pull request
May 13, 2014
Share reconcile transaction in batched updates
josephsavona
pushed a commit
that referenced
this pull request
May 15, 2024
--- +10 −1,698 lines [[insert impacc macro]] The ObjectShape stacks (#1350, #1358) used these tests to record changes in inferred types (and associated ObjectShapes), reference effects, and mutable ranges. Now that those PRs have landed, we can delete these tests. They are somewhat fragile (changing anytime HIR / printHIR is changed) and easily cause rebase/merge conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make #1350 better and will also take away any performance hit from #1157.
Test Plan:
grunt test
cc @sebmarkbage @jordwalke @nathansobo