Batch subupdates caused by any state update #1363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| len === dirtyComponents.length, | ||
| "Expected flush transaction's stored dirty-components " + | ||
| "length (" + len + ") to match dirty-components array " + | ||
| "length (" + dirtyComponents.length + ")." |
There was a problem hiding this comment.
Could use single quotes and %s here for consistency?
With this, multiple setState calls triggered by a componentDidUpdate handler (or similar) will be batched together, regardless of if the original setState call was in a batching context. I also cleaned up some inconsistencies with the order of component updates and callbacks in situations where one component's update directly causes another to update. Fixes facebook#1147. Helps with facebook#1353 and facebook#1245 as well, though doesn't completely fix them yet. Test Plan: grunt test
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
zpao
added a commit
that referenced
this pull request
May 22, 2014
Batch subupdates caused by any state update
This was referenced May 23, 2014
sophiebits
added a commit
to sophiebits/react-art
that referenced
this pull request
May 29, 2014
Counterpart to facebook/react#1363.
sophiebits
added a commit
to sophiebits/react-art
that referenced
this pull request
May 29, 2014
Counterpart to facebook/react#1363.
superbuddyy
added a commit
to superbuddyy/react-art-world
that referenced
this pull request
Aug 9, 2022
Counterpart to facebook/react#1363.
Oleksandr0305
added a commit
to Oleksandr0305/react-art
that referenced
this pull request
Jan 31, 2025
Counterpart to facebook/react#1363.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, multiple setState calls triggered by a componentDidUpdate handler (or similar) will be batched together, regardless of if the original setState call was in a batching context.
I also cleaned up some inconsistencies with the order of component updates and callbacks in situations where one component's update directly causes another to update.
Fixes #1147 and #983. Helps with #1353 and #1245 as well, though doesn't completely fix them yet.
Test Plan:
grunt test
Depends on #1362 and #1358.