fix: Use probe side column name for input column type and update SS check usage #16205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
|
@xiaoxmeng has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92024520. |
breeze1990
approved these changes
Feb 2, 2026
tanjialiang
approved these changes
Feb 2, 2026
zacw7
approved these changes
Feb 2, 2026
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Feb 2, 2026
…heck usage (facebookincubator#16205) Summary: Fix a bug in `IndexLookupJoin.cpp` where the lookup input column was incorrectly using `indexKeyName` instead of `probeKeyName` Replaces all `VELOX_CHECK*` macros with their `SS_CHECK*` equivalents in `SequenceStorageIndexSource.cpp` to use the Sequence Storage-specific exception handling macros for better error categorization and consistency. Reviewed By: breeze1990, ximyu Differential Revision: D92024520
xiaoxmeng
force-pushed
the
export-D92024520
branch
from
69d40d5 to
24bcafc
Compare
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Feb 2, 2026
…heck usage (facebookincubator#16205) Summary: Fix a bug in `IndexLookupJoin.cpp` where the lookup input column was incorrectly using `indexKeyName` instead of `probeKeyName` Replaces all `VELOX_CHECK*` macros with their `SS_CHECK*` equivalents in `SequenceStorageIndexSource.cpp` to use the Sequence Storage-specific exception handling macros for better error categorization and consistency. Reviewed By: breeze1990, ximyu Differential Revision: D92024520
xiaoxmeng
force-pushed
the
export-D92024520
branch
from
24bcafc to
5031df8
Compare
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Feb 2, 2026
…cebookincubator#16205) Summary: Fix lookup input column naming: In IndexLookupJoin.cpp, the lookup input column was incorrectly using indexKeyName (the index table's column name) instead of probeKeyName (the probe side's column name). This caused column name mismatches when the probe and index tables have different column names for the same join key. The fix ensures the lookup input type uses probe side column names, which are then mapped to index column names through lookupInputProjections_. Deduplicate lookup input columns: When the same input column is used in multiple join conditions (e.g., a column used for both lower and upper bounds in a BETWEEN condition, or the same column appearing in multiple conditions), it was being added multiple times to inputType_, causing duplicate columns in the row type. Added folly::F14FastSet<std::string> lookupInputColumnSet to track seen columns and only add each column once to the lookup input. Replaces all `VELOX_CHECK*` macros with their `SS_CHECK*` equivalents in `SequenceStorageIndexSource.cpp` to use the Sequence Storage-specific exception handling macros for better error categorization and consistency. bypass-github-export-checks Reviewed By: breeze1990, ximyu Differential Revision: D92024520
xiaoxmeng
force-pushed
the
export-D92024520
branch
from
5031df8 to
3226860
Compare
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Feb 3, 2026
…cebookincubator#16205) Summary: Fix lookup input column naming: In IndexLookupJoin.cpp, the lookup input column was incorrectly using indexKeyName (the index table's column name) instead of probeKeyName (the probe side's column name). This caused column name mismatches when the probe and index tables have different column names for the same join key. The fix ensures the lookup input type uses probe side column names, which are then mapped to index column names through lookupInputProjections_. Deduplicate lookup input columns: When the same input column is used in multiple join conditions (e.g., a column used for both lower and upper bounds in a BETWEEN condition, or the same column appearing in multiple conditions), it was being added multiple times to inputType_, causing duplicate columns in the row type. Added folly::F14FastSet<std::string> lookupInputColumnSet to track seen columns and only add each column once to the lookup input. Replaces all `VELOX_CHECK*` macros with their `SS_CHECK*` equivalents in `SequenceStorageIndexSource.cpp` to use the Sequence Storage-specific exception handling macros for better error categorization and consistency. bypass-github-export-checks Reviewed By: breeze1990, ximyu Differential Revision: D92024520
xiaoxmeng
force-pushed
the
export-D92024520
branch
from
3226860 to
17a0cda
Compare
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Feb 3, 2026
…cebookincubator#16205) Summary: Fix lookup input column naming: In IndexLookupJoin.cpp, the lookup input column was incorrectly using indexKeyName (the index table's column name) instead of probeKeyName (the probe side's column name). This caused column name mismatches when the probe and index tables have different column names for the same join key. The fix ensures the lookup input type uses probe side column names, which are then mapped to index column names through lookupInputProjections_. Deduplicate lookup input columns: When the same input column is used in multiple join conditions (e.g., a column used for both lower and upper bounds in a BETWEEN condition, or the same column appearing in multiple conditions), it was being added multiple times to inputType_, causing duplicate columns in the row type. Added folly::F14FastSet<std::string> lookupInputColumnSet to track seen columns and only add each column once to the lookup input. Replaces all `VELOX_CHECK*` macros with their `SS_CHECK*` equivalents in `SequenceStorageIndexSource.cpp` to use the Sequence Storage-specific exception handling macros for better error categorization and consistency. bypass-github-export-checks Reviewed By: breeze1990, ximyu Differential Revision: D92024520
xiaoxmeng
force-pushed
the
export-D92024520
branch
from
17a0cda to
268787a
Compare
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Feb 3, 2026
…cebookincubator#16205) Summary: Fix lookup input column naming: In IndexLookupJoin.cpp, the lookup input column was incorrectly using indexKeyName (the index table's column name) instead of probeKeyName (the probe side's column name). This caused column name mismatches when the probe and index tables have different column names for the same join key. The fix ensures the lookup input type uses probe side column names, which are then mapped to index column names through lookupInputProjections_. Deduplicate lookup input columns: When the same input column is used in multiple join conditions (e.g., a column used for both lower and upper bounds in a BETWEEN condition, or the same column appearing in multiple conditions), it was being added multiple times to inputType_, causing duplicate columns in the row type. Added folly::F14FastSet<std::string> lookupInputColumnSet to track seen columns and only add each column once to the lookup input. Replaces all `VELOX_CHECK*` macros with their `SS_CHECK*` equivalents in `SequenceStorageIndexSource.cpp` to use the Sequence Storage-specific exception handling macros for better error categorization and consistency. bypass-github-export-checks Reviewed By: breeze1990, ximyu Differential Revision: D92024520
xiaoxmeng
force-pushed
the
export-D92024520
branch
from
268787a to
9be66e7
Compare
…cebookincubator#16205) Summary: Fix lookup input column naming: In IndexLookupJoin.cpp, the lookup input column was incorrectly using indexKeyName (the index table's column name) instead of probeKeyName (the probe side's column name). This caused column name mismatches when the probe and index tables have different column names for the same join key. The fix ensures the lookup input type uses probe side column names, which are then mapped to index column names through lookupInputProjections_. Deduplicate lookup input columns: When the same input column is used in multiple join conditions (e.g., a column used for both lower and upper bounds in a BETWEEN condition, or the same column appearing in multiple conditions), it was being added multiple times to inputType_, causing duplicate columns in the row type. Added folly::F14FastSet<std::string> lookupInputColumnSet to track seen columns and only add each column once to the lookup input. Replaces all `VELOX_CHECK*` macros with their `SS_CHECK*` equivalents in `SequenceStorageIndexSource.cpp` to use the Sequence Storage-specific exception handling macros for better error categorization and consistency. bypass-github-export-checks Reviewed By: breeze1990, ximyu Differential Revision: D92024520
xiaoxmeng
force-pushed
the
export-D92024520
branch
from
9be66e7 to
c19f8d3
Compare
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Feb 3, 2026
…cebookincubator#16205) Summary: Fix lookup input column naming: In IndexLookupJoin.cpp, the lookup input column was incorrectly using indexKeyName (the index table's column name) instead of probeKeyName (the probe side's column name). This caused column name mismatches when the probe and index tables have different column names for the same join key. The fix ensures the lookup input type uses probe side column names, which are then mapped to index column names through lookupInputProjections_. Deduplicate lookup input columns: When the same input column is used in multiple join conditions (e.g., a column used for both lower and upper bounds in a BETWEEN condition, or the same column appearing in multiple conditions), it was being added multiple times to inputType_, causing duplicate columns in the row type. Added folly::F14FastSet<std::string> lookupInputColumnSet to track seen columns and only add each column once to the lookup input. Replaces all `VELOX_CHECK*` macros with their `SS_CHECK*` equivalents in `SequenceStorageIndexSource.cpp` to use the Sequence Storage-specific exception handling macros for better error categorization and consistency. bypass-github-export-checks Reviewed By: breeze1990, ximyu Differential Revision: D92024520
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Feb 3, 2026
…cebookincubator#16205) Summary: Fix lookup input column naming: In IndexLookupJoin.cpp, the lookup input column was incorrectly using indexKeyName (the index table's column name) instead of probeKeyName (the probe side's column name). This caused column name mismatches when the probe and index tables have different column names for the same join key. The fix ensures the lookup input type uses probe side column names, which are then mapped to index column names through lookupInputProjections_. Deduplicate lookup input columns: When the same input column is used in multiple join conditions (e.g., a column used for both lower and upper bounds in a BETWEEN condition, or the same column appearing in multiple conditions), it was being added multiple times to inputType_, causing duplicate columns in the row type. Added folly::F14FastSet<std::string> lookupInputColumnSet to track seen columns and only add each column once to the lookup input. Replaces all `VELOX_CHECK*` macros with their `SS_CHECK*` equivalents in `SequenceStorageIndexSource.cpp` to use the Sequence Storage-specific exception handling macros for better error categorization and consistency. bypass-github-export-checks Reviewed By: breeze1990, ximyu Differential Revision: D92024520
PingLiuPing
pushed a commit
to PingLiuPing/velox
that referenced
this pull request
Feb 3, 2026
…cebookincubator#16205) Summary: Pull Request resolved: facebookincubator#16205 Fix lookup input column naming: In IndexLookupJoin.cpp, the lookup input column was incorrectly using indexKeyName (the index table's column name) instead of probeKeyName (the probe side's column name). This caused column name mismatches when the probe and index tables have different column names for the same join key. The fix ensures the lookup input type uses probe side column names, which are then mapped to index column names through lookupInputProjections_. Deduplicate lookup input columns: When the same input column is used in multiple join conditions (e.g., a column used for both lower and upper bounds in a BETWEEN condition, or the same column appearing in multiple conditions), it was being added multiple times to inputType_, causing duplicate columns in the row type. Added folly::F14FastSet<std::string> lookupInputColumnSet to track seen columns and only add each column once to the lookup input. Replaces all `VELOX_CHECK*` macros with their `SS_CHECK*` equivalents in `SequenceStorageIndexSource.cpp` to use the Sequence Storage-specific exception handling macros for better error categorization and consistency. bypass-github-export-checks Reviewed By: breeze1990, ximyu Differential Revision: D92024520 fbshipit-source-id: 23bec9f72ce854a3e2d737ade8a741a053648682
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix a bug in
IndexLookupJoin.cppwhere the lookup input column was incorrectly usingindexKeyNameinstead ofprobeKeyNameReplaces all
VELOX_CHECK*macros with theirSS_CHECK*equivalents inSequenceStorageIndexSource.cppto use the Sequence Storage-specific exception handling macros for better error categorization and consistency.Differential Revision: D92024520