feat: Add retry logic for remote function calls #16233
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 3, 2026 17:45
…ebookincubator#16231) Summary: Refactored the remote function client to use dependency injection, enabling proper mocking in tests: 1. Added `IRemoteFunctionClient` abstract interface in ThriftClient.h with `invokeFunction()` method 2. Added `ThriftRemoteFunctionClient` default implementation that wraps the actual thrift client 3. Added `RemoteFunctionClientFactory` type alias for creating clients 4. Added optional `clientFactory` field to `RemoteThriftVectorFunctionMetadata` 5. Modified `RemoteThriftFunction` to use injected factory (with fallback to default) 6. Added `MockRemoteFunctionTest` test fixture demonstrating mock client usage 7. Added 3 new tests using mock clients instead of real thrift server This allows tests to inject mock clients instead of requiring a real thrift server, making tests faster and more isolated. Differential Revision: D92213049
Summary: This diff adds retry logic with exponential backoff for remote function calls in the Velox client, ported from D91729467. **Changes:** - Add retry logic with exponential backoff for TTransportException and AsyncSocketException errors - Automatically reconnect the thrift client after transport failures - Configurable via `--remote_function_retry_count` (default: 3) and `--remote_function_retry_max_backoff_sec` (default: 8) - Extract common retry logic into `handleRetryableError()` helper to avoid code duplication - Fix jitter distribution to use range [0.5, expIntervalSec + 0.5) to ensure meaningful backoff on first retry - Add unit tests for retry behavior and gflag defaults Differential Revision: D92204805
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds retry logic with exponential backoff for remote function calls in the Velox client, ported from D91729467.
Changes:
--remote_function_retry_count(default: 3) and--remote_function_retry_max_backoff_sec(default: 8)handleRetryableError()helper to avoid code duplicationDifferential Revision: D92204805