Skip to content

[BE] cleanup docstring sims.habitat_simulator.sim_utilities#2009

Merged
aclegg3 merged 9 commits into
mainfrom
daniel-07_18-cleanup_docstring_sims_habitatsimulator_sim_utilities
Aug 14, 2024
Merged

[BE] cleanup docstring sims.habitat_simulator.sim_utilities#2009
aclegg3 merged 9 commits into
mainfrom
daniel-07_18-cleanup_docstring_sims_habitatsimulator_sim_utilities

Conversation

@aclegg3

@aclegg3 aclegg3 commented Aug 13, 2024

Copy link
Copy Markdown
Contributor

Motivation and Context

This PR adds remaining docstrings for sim_utilities and removes several aabb related functions which were made redundant by facebookresearch/habitat-sim#2421

How Has This Been Tested

CI for functionality
TODO: Daniel to review docstrings

Types of changes

  • [Docs change] Addition or changes to the documentation
  • [Refactoring] Large changes to the code that improve its functionality or performance

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 13, 2024

@danieltmeta danieltmeta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aclegg3 Docstring annotations approved.

@aclegg3 aclegg3 merged commit 868b549 into main Aug 14, 2024
@aclegg3 aclegg3 deleted the daniel-07_18-cleanup_docstring_sims_habitatsimulator_sim_utilities branch August 14, 2024 20:01
joannetruong pushed a commit that referenced this pull request Mar 12, 2025
* add module docstring and remove now-redundant ao_root_bbs function

---------

Co-authored-by: trandaniel <trandaniel@meta.com>
Zeying-Gong pushed a commit to Zeying-Gong/Falcon that referenced this pull request Mar 31, 2025
…research#2009)

* add module docstring and remove now-redundant ao_root_bbs function

---------

Co-authored-by: trandaniel <trandaniel@meta.com>
Aawangas pushed a commit to Supramundaner/habitat-labForReasonNavi that referenced this pull request Aug 14, 2025
…research#2009)

* add module docstring and remove now-redundant ao_root_bbs function

---------

Co-authored-by: trandaniel <trandaniel@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants