Skip to content

ManagedObject.getAabb()#2421

Merged
aclegg3 merged 11 commits intomainfrom
alex-06_26-bb_utils
Jul 3, 2024
Merged

ManagedObject.getAabb()#2421
aclegg3 merged 11 commits intomainfrom
alex-06_26-bb_utils

Conversation

@aclegg3
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 commented Jul 2, 2024

Motivation and Context

Adds a standard API function for querying the AABB of ManagedObjects.

In C++:

ManagedObject.getAabb()

In python (property):

obj.aabb

For ManagedArticulatedObjects, this function computes the cumulative bounding box from all the child links in the current state. A dirty flag is cached to ensure that re-computation effort is only applied when querying the property after a state change.

How Has This Been Tested

New tests are added to check that the function works for rigids with golden number and for AOs that all links are within the computed cumulative bounding box.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested review from 0mdc and jturner65 July 2, 2024 18:15
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 2, 2024
Copy link
Copy Markdown
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question/suggestion

Comment thread src_python/habitat_sim/simulator.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants