Conversation
jturner65
approved these changes
Jul 2, 2024
Contributor
jturner65
left a comment
There was a problem hiding this comment.
Just one question/suggestion
5 tasks
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Adds a standard API function for querying the AABB of ManagedObjects.
In C++:
In python (property):
For
ManagedArticulatedObjects, this function computes the cumulative bounding box from all the child links in the current state. A dirty flag is cached to ensure that re-computation effort is only applied when querying the property after a state change.How Has This Been Tested
New tests are added to check that the function works for rigids with golden number and for AOs that all links are within the computed cumulative bounding box.
Types of changes
Checklist