[Clang-Tidy] Enable readability string compare check

[Skylion007]

Motivation and Context

• This enables a clang-tidy check that discourages the .compare operator to compare strings. There are two reasons for this:
• This form is more readable.
• It can early terminate unlike compare and is therefore more performant.
  Given these two benefits, I don't see any reason to use the old fashioned string compares. All fixes in this PR were automated by clang-tidy.

How Has This Been Tested

• CI

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)

Checklist

• My code follows the code style of this project.
• I have read the CONTRIBUTING document.
• I have completed my CLA (see CONTRIBUTING)
• I have added tests to cover my changes.
• All new and existing tests passed.

[jturner65]

LGTM