Conversation
…ion instead of local "up"
facebook-github-bot
added
the
CLA Signed
Skylion007
approved these changes
May 25, 2022
jturner65
approved these changes
May 25, 2022
Skylion007
reviewed
May 26, 2022
| object.translateLocal(object.transformation().up() * distance); | ||
| // Note: this is not a body action and is applied to the sensor rather than | ||
| // the Agent, so it will move the sensor in Agent's +Y (up) direction | ||
| object.translate(Magnum::Vector3(0, 1, 0) * distance); |
Contributor
There was a problem hiding this comment.
@aclegg3 This is a magic number (or rather vector). May want to make it a global constant somewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
moveUpandmoveDownactions (in C++) are used exclusively in the viewer application to raise and lower the agent camera. Current implementation uses camera local "up" translation. When the camera is pitched this results in moving the camera node off-axis, changing the axis of rotation.This PR changes moveUp and moveDown action to apply parent coordinate system +Y translation instead of local "up" so the camera always stays constrained to the agent's "up" axis.
If moving the camera off-axis is desirable it should be implemented as a separate action.
How Has This Been Tested
Local in viewer.
Types of changes
Checklist