Skip to content

[bugfix] - moveUp moveDown #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aclegg3 merged 1 commit into from
Jun 1, 2022
Merged

[bugfix] - moveUp moveDown #1763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/esp/scene/ObjectControls.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ SceneNode& moveLeft(SceneNode& object, float distance) {

SceneNode& moveUp(SceneNode& object, float distance) {
// TODO: this assumes no scale is applied
object.translateLocal(object.transformation().up() * distance);
// Note: this is not a body action and is applied to the sensor rather than
// the Agent, so it will move the sensor in Agent's +Y (up) direction
object.translate(Magnum::Vector3(0, 1, 0) * distance);
Copy link
Copy Markdown
Contributor

@Skylion007 Skylion007 May 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aclegg3 This is a magic number (or rather vector). May want to make it a global constant somewhere.

return object;
}

Expand Down