Merged
Conversation
…recompute on reconfigure to C++. Remove automatic application of agent height and radius settings.
This was referenced May 18, 2023
0mdc
approved these changes
May 31, 2023
Contributor
0mdc
left a comment
There was a problem hiding this comment.
LGTM! I left some minor remarks.
| #include <string> | ||
|
|
||
| #include "esp/core/Esp.h" | ||
| #include "esp/nav/PathFinder.h" |
Contributor
There was a problem hiding this comment.
This should probably be forward-declared as this class is widely used.
Contributor
Author
There was a problem hiding this comment.
Yeah, I thought so too. However, the compiler does not like the forward declaration here, so I needed the full the include.
This was referenced Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Several recent needs have exposed the brittleness of current NavMesh defaults for Simulator reconfiguration. This PR aims to provide much more flexibility in configuration and reduce unnecessary compute while remaining simple for default use-cases.
This is a breaking change.
Currently, when a Simulator is initialized, the default agent radius and height are used to trigger a re-compute of the NavMesh if any other settings are modified. This cannot be turned off and other settings cannot be modified without explicitly recomputing again after instantiation which can be costly in aggregate and occasionally block use-ability altogether (e.g. if some property of the stage causes navmesh computation to fail).
After this change:
Habitat-lab will need to be updated to use the new API. facebookresearch/habitat-lab#1351
Should cover the needs of #2104.
How Has This Been Tested
Updated tests should cover this.
I did additional local testing with python viewer to double check.
Types of changes
Checklist