Skip to content

Adds HSSD to dataset downloader#2163

Merged
aclegg3 merged 6 commits intofacebookresearch:mainfrom
mukulkhanna:hssd-huggingface-porting
Jul 28, 2023
Merged

Adds HSSD to dataset downloader#2163
aclegg3 merged 6 commits intofacebookresearch:mainfrom
mukulkhanna:hssd-huggingface-porting

Conversation

@mukulkhanna
Copy link
Copy Markdown
Contributor

@mukulkhanna mukulkhanna commented Jul 20, 2023 •
edited by aclegg3
Loading

Motivation and Context

Adds HSSD and AI2THOR-hab scenes and episode datasets to the dataset downloader.

How Has This Been Tested

Locally by running the downloader for each of the added entries.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mukulkhanna mukulkhanna requested a review from aclegg3 July 20, 2023 17:37
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 20, 2023
aclegg3
aclegg3 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Maybe one minor change to auth on hssd-scenes?

Comment thread src_python/habitat_sim/utils/datasets_download.py Outdated
@aclegg3 aclegg3 merged commit e6ef7b1 into facebookresearch:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

Assignees

No one assigned

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mukulkhanna @aclegg3 @facebook-github-bot