Fixing bug in mesh rasterizer #1392
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g if projection transform exists.
facebook-github-bot
added
the
CLA Signed
bottler
reviewed
Dec 15, 2022
| # Call transform_points instead of explicitly composing transforms to handle | ||
| # the case, where camera class does not have a projection matrix form. | ||
| verts_proj = cameras.transform_points(verts_world, eps=eps) | ||
| to_ndc_transform = cameras.get_ndc_camera_transform(**kwargs) |
Contributor
There was a problem hiding this comment.
Did you mean to leave this line in and only remove the previous line? If so, then I think the fix is right.
Contributor
Author
There was a problem hiding this comment.
Yes, sorry for that. I only meant to remove the line containing the camera.transform_points() and the comment, as it makes more sense in the else part.
Contributor
Author
There was a problem hiding this comment.
I created a second commit in the branch to resolve the issue. Let me know if you want a new pull request.
Contributor
Author
There was a problem hiding this comment.
Created a new pull request where the issue is fixed.
Contributor
Author
|
Created an updated pull request, closing this. |
Contributor
Thanks. It's #1421 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the file rasterizer.py there are duplicate lines before the check if the
projection_transformexists. These cause an exception in the case that a projection transform matrix is already provided. The corresponding lines should be (and are already) in the else case of the if-statement.Removing these lines fixes the bug and produces the desired behaviour.