Skip to content

Fixing bug in mesh rasterizer #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
myla wants to merge 3 commits into from
Closed

Fixing bug in mesh rasterizer #1392

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e30122
Removing duplicate lines that calls transform_points() before checkin…
Dec 10, 2022
f0c9e34
Re-inserted falsely removed line for mdc transform
myla Jan 10, 2023
244e50d
Merge branch 'main' into project-transform-patch
myla Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions pytorch3d/renderer/mesh/rasterizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,6 @@ def transform(self, meshes_world, **kwargs) -> torch.Tensor:
verts_view = cameras.get_world_to_view_transform(**kwargs).transform_points(
verts_world, eps=eps
)
# Call transform_points instead of explicitly composing transforms to handle
# the case, where camera class does not have a projection matrix form.
verts_proj = cameras.transform_points(verts_world, eps=eps)
to_ndc_transform = cameras.get_ndc_camera_transform(**kwargs)
Copy link
Contributor

@bottler bottler Dec 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to leave this line in and only remove the previous line? If so, then I think the fix is right.

Copy link
Contributor Author

@myla myla Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry for that. I only meant to remove the line containing the camera.transform_points() and the comment, as it makes more sense in the else part.

Copy link
Contributor Author

@myla myla Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a second commit in the branch to resolve the issue. Let me know if you want a new pull request.

Copy link
Contributor Author

@myla myla Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a new pull request where the issue is fixed.

projection_transform = try_get_projection_transform(cameras, kwargs)
if projection_transform is not None:
projection_transform = projection_transform.compose(to_ndc_transform)
Expand Down