Skip to content

update to python3.10 #22 #23 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

update to python3.10 #22 #23 #28

wants to merge 1 commit into from

Conversation

wu-clan
Copy link
Member

@wu-clan wu-clan commented Apr 29, 2023

Please note that this pr does not work properly and needs to be checked and repaired.

@wu-clan wu-clan requested a review from downdawn April 29, 2023 05:47
@wu-clan wu-clan linked an issue Apr 29, 2023 that may be closed by this pull request
@downdawn
Copy link
Collaborator

downdawn commented Apr 29, 2023

Every py file needs to import annotations, isn't it a bit intrusive?

Isn't using TYPE_CHECKING a bit too harsh?

If so, I feel like it might be better to primarily support one python version. 3.8 or 3.10.

@wu-clan
Copy link
Member Author

wu-clan commented Apr 30, 2023

Annotation is already the default behavior in 3.10, and there is no need to import it manually.

Can refuse to use TYPE_CHECKING, but it seems that there will be a little performance optimization?

They can be managed through ruff. It works very well.

@downdawn
Copy link
Collaborator

Yes, so I prefer 3.10

For the time being, we can ignore TYPE_CHECKING the performance improvements that come with type_checking, which should be simple and efficient.

ruff works well, and I've looked at their documentation

@wu-clan
Copy link
Member Author

wu-clan commented Apr 30, 2023

No problem, let‘s start directly from 3.10. People who like it also need 3.10, and need to add it to readme as a reminder.

@wu-clan
Copy link
Member Author

wu-clan commented Apr 30, 2023

I’d be happy if you could update the code directly.

I can‘t code it for the time being these days……

@wu-clan
Copy link
Member Author

wu-clan commented May 3, 2023

Thank you for @downdawn PR #29

@wu-clan wu-clan closed this May 3, 2023
@wu-clan wu-clan deleted the support-py3.10 branch May 3, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade python base version to python 3.10
2 participants