Skip to content

update to python3.10 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2023
Merged

update to python3.10 #29

merged 2 commits into from
May 3, 2023

Conversation

downdawn
Copy link
Collaborator

@downdawn downdawn commented May 2, 2023

https://github.com/fastapi-practices/fastapi_best_architecture/pull/28

ignore = ["F401"]

Some need to ignore some don't

For example from typing import Optional

@wu-clan
Copy link
Member

wu-clan commented May 3, 2023

Can delete the global ignore=["F401"]

Add one by one to per-file-ignore

@downdawn
Copy link
Collaborator Author

downdawn commented May 3, 2023

OK, updated

@wu-clan
Copy link
Member

wu-clan commented May 3, 2023

Thanks,very nice.

@wu-clan wu-clan self-requested a review May 3, 2023 08:58
Copy link
Member

@wu-clan wu-clan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@wu-clan wu-clan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wu-clan wu-clan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wu-clan wu-clan merged commit 64f2a13 into fastapi-practices:master May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants