-
Notifications
You must be signed in to change notification settings - Fork 462
Fix version extraction in Sphinx config #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmduarte
reviewed
Oct 26, 2022
@vloncar what a nightmare trying to get the
Now it works. |
jmduarte
approved these changes
Oct 26, 2022
@jmduarte I fixed the failing test of reading h5 file. It failed in quartus for unrelated reason, due to the name of the project not being propagated. Ready to (squash and) merge now? |
calad0i
pushed a commit
to calad0i/hls4ml
that referenced
this pull request
Jul 1, 2023
* Fix version extraction in Sphinx config * format * Use get_version from setuptools_scm * minor fixes; try with reqs * add test sphinx * try installing git * update reqs * try installing git again * apt-get * try different action * updated image * custom docker image * update tests * Ensure the project name is propagated in Quartus writer Co-authored-by: Javier Duarte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the merging of #479 the location of
__version__
changed and Sphinx config still tries to extract it fromhls4ml/__init__.py
. This changes the config of Sphinx to extract the version information from the new_version.py
.Type of change