-
Notifications
You must be signed in to change notification settings - Fork 462
CNNs with binary inputs and weights need fixes #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before I pushed 7186346 the test results were:
After, they all fail. So it was not a successful fix. |
This is not complete, and the final test has been disabled, but I think the fixes that we have here should be added before we make 0.7.0 RC. The other stuff we can add after the RC is built or later. The remaining to-dos:
If this is accepted, those to-dos should be moved to an issue. |
This fixes a few things:
|
vloncar
approved these changes
Apr 24, 2023
JanFSchulte
pushed a commit
to JanFSchulte/hls4ml
that referenced
this pull request
May 23, 2023
* fix cast in remaining places for binary CNNs * add pytest for binary cnn * attempted fix for streaming normalize_binary_tanh and normalize_ternary_tanh * make all compile, though test differences are still too large * update pytest, disable comparison for now * remove setting of precision in max pool * specify the full path out test output
calad0i
pushed a commit
to calad0i/hls4ml
that referenced
this pull request
Jul 1, 2023
* fix cast in remaining places for binary CNNs * add pytest for binary cnn * attempted fix for streaming normalize_binary_tanh and normalize_ternary_tanh * make all compile, though test differences are still too large * update pytest, disable comparison for now * remove setting of precision in max pool * specify the full path out test output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As shown by #740, CNNs with binary quantizers don't currently work properly. This PR attempts to fix it.
Type of change
Tests
A pytest is added. However, it still shows errors in streaming.
Checklist
pre-commit
on the files I edited or added.