Rename and publish context schema files #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikoe
commented
Feb 9, 2020
rikoe
commented
Feb 9, 2020
rikoe
commented
Feb 9, 2020
nkolba
reviewed
Feb 10, 2020
- Change schema file extensions - Change schema $id property to use correct target URI (without version, but "next" instead) - Change "enum" for "type" to be "const", which is the more correct JSON schema usage - Some changes to some types to bring in line with FinObj types
- Copy to schemas/next folder with npm command - Make part of website pre-publish script during build - Update links in context schema spec to point to published schemas
- remove FDS_ID from contact - make holding mandatory on position
rikoe
force-pushed
the
publish-schema-files
branch
from
17cec02 to
e422c08
Compare
nkolba
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$idproperty to use correct target URI (without version, but "next" instead)website/static/schemas/nextfolder as part of build