Skip to content

Remove TwitterSignInHandler because its dependency TwitterKit is deprecated. #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
efrohnhoefer opened this issue Apr 29, 2019 · 2 comments
Closed

Remove TwitterSignInHandler because its dependency TwitterKit is deprecated. #1626

efrohnhoefer opened this issue Apr 29, 2019 · 2 comments
Labels
auth fix-implemented refactor
Milestone
6.2.0

Comments

@efrohnhoefer
Copy link

efrohnhoefer commented Apr 29, 2019 •
edited
Loading

See: https://blog.twitter.com/developer/en_us/topics/tools/2018/discontinuing-support-for-twitter-kit-sdk.html
See: firebase/FirebaseUI-iOS#650
efrohnhoefer pushed a commit to efrohnhoefer/FirebaseUI-Android that referenced this issue Apr 29, 2019
Remove TwitterSignInHandler because its dependency TwitterKit is depr…
0dca5a2 
…ecated.

Closes: firebase#1626
@lsirac
Copy link
Contributor

lsirac commented Apr 29, 2019

We can't remove this and replace it with Generic IDP just yet, some changes are needed. Generic IDP was focused on providers supporting OAuth2 while Twitter uses OAuth1 for user authentication.

We're going to be making some changes to support this, and then we'll replace it with Generic IDP.

Releases work differently for Android, which is why it'll take longer :(

efrohnhoefer pushed a commit to efrohnhoefer/FirebaseUI-Android that referenced this issue Apr 29, 2019
Remove TwitterSignInHandler because its dependency TwitterKit is depr…
9d7a8e3 
…ecated.

Closes: firebase#1626
@efrohnhoefer efrohnhoefer mentioned this issue Apr 29, 2019
Closed
@samtstern samtstern added this to the 6.2.0 milestone Nov 19, 2019
@samtstern samtstern modified the milestones: 6.2.1, 6.2.0 Dec 16, 2019
@samtstern
Copy link
Contributor

Version 6.2.0 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auth fix-implemented refactor
Projects
None yet
Milestone
6.2.0
3 participants
@efrohnhoefer @samtstern @lsirac