Remove TwitterAuthUI because its dependency TwitterKit is deprecated. #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yue-Wang-Google
force-pushed
the
delete_twitter_kit
branch
from
50357ab to
569d5a1
Compare
|
DO_NOT_SUBMIT. We will deprecate TwitterAuth first in the next release. This PR will be useful after the next release is out. |
|
Twitter deprecation PR was just submitted to Firebase SDK. See firebase/firebase-ios-sdk#2663 . Reopen this PR. |
|
Please hold off review. I will need to implement Twitter auth using OAuth. |
Yue-Wang-Google
force-pushed
the
delete_twitter_kit
branch
from
a9716cd to
5ae3285
Compare
|
Code is available for review. |
renkelvin
approved these changes
Apr 4, 2019
|
travis is drunk. It failed at the same place as #663 while the latter could always gets passed. As none of our UI tests work right now, I'll just submit this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are encouraged to use OAuth login instead.