Skip to content

Remove TwitterAuthUI because its dependency TwitterKit is deprecated. #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Auth/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ pod 'FirebaseUI/Auth'
pod 'FirebaseUI/Email'
pod 'FirebaseUI/Google'
pod 'FirebaseUI/Facebook'
pod 'FirebaseUI/Twitter'
pod 'FirebaseUI/Phone'
```

Expand All @@ -48,7 +47,6 @@ Auth guides at the following links:
- [Email and password](https://firebase.google.com/docs/auth/ios/password-auth#before_you_begin)
- [Google](https://firebase.google.com/docs/auth/ios/google-signin#before_you_begin)
- [Facebook](https://firebase.google.com/docs/auth/ios/facebook-login#before_you_begin)
- [Twitter](https://firebase.google.com/docs/auth/ios/twitter-login#before_you_begin)
- [Phone](https://firebase.google.com/docs/auth/ios/phone-auth#before_you_begin)

## Using FirebaseUI for Authentication
Expand Down Expand Up @@ -95,7 +93,6 @@ let providers: [FUIAuthProvider] = [
FUIEmailAuth(),
FUIGoogleAuth(),
FUIFacebookAuth(),
FUITwitterAuth(),
FUIPhoneAuth(authUI: FUIAuth.defaultAuthUI()),
]
self.authUI?.providers = providers
Expand All @@ -111,7 +108,6 @@ NSArray<id<FUIAuthProvider>> *providers = @[
[[FUIEmailAuth alloc] init],
[[FUIGoogleAuth alloc] init],
[[FUIFacebookAuth alloc] init],
[[FUITwitterAuth alloc] init],
[[FUIPhoneAuth alloc] initWithAuthUI:[FUIAuth defaultAuthUI]]
];
_authUI.providers = providers;
Expand Down
1 change: 0 additions & 1 deletion FirebaseUI.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,4 @@ FOUNDATION_EXPORT const unsigned char FirebaseUIVersionString[];
#import <FirebaseUI/FirebaseGoogleAuthUI.h>
#import <FirebaseUI/FirebaseOAuthUI.h>
#import <FirebaseUI/FirebasePhoneAuthUI.h>
#import <FirebaseUI/FirebaseTwitterAuthUI.h>
#import <FirebaseUI/FirebaseStorageUI.h>
11 changes: 0 additions & 11 deletions FirebaseUI.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -148,15 +148,4 @@ Pod::Spec.new do |s|
phone.xcconfig = { 'HEADER_SEARCH_PATHS' => '$(PODS_ROOT)/FirebaseUI/FirebasePhoneAuthUI' }
end

s.subspec 'Twitter' do |twitter|
twitter.public_header_files = 'TwitterAuth/FirebaseTwitterAuthUI/*.h'
twitter.source_files = 'TwitterAuth/FirebaseTwitterAuthUI/*.{h,m}'
twitter.dependency 'FirebaseUI/Auth'
twitter.dependency 'TwitterKit', '~> 3.0'
twitter.platform = :ios, '9.0'
twitter.resource_bundle = {
'FirebaseTwitterAuthUI' => ['TwitterAuth/FirebaseTwitterAuthUI/**/*.{png,lproj}']
}
twitter.xcconfig = { 'HEADER_SEARCH_PATHS' => '$(PODS_ROOT)/FirebaseUI/FirebaseTwitterAuthUI' }
end
end
4 changes: 0 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ pod 'FirebaseUI/Facebook', '~> 5.0'
# Only pull in Google login features
pod 'FirebaseUI/Google', '~> 5.0'

# Only pull in Twitter login features
pod 'FirebaseUI/Twitter', '~> 5.0'

# Only pull in Phone Auth login features
pod 'FirebaseUI/Phone', '~> 5.0'
```
Expand Down Expand Up @@ -92,7 +89,6 @@ Copy the `GoogleService-Info.plist` into the sample project folder (`samples/obj
Go to `Project Settings -> Info tab -> Url Types` and update values for:
+ `REVERSED_CLIENT_ID` (get value from `GoogleService-Info.plist`)
+ `fb{your-app-id}` (put Facebook App Id)
+ `twitterkit-{consumer-key}` (put Twitter App Consumer key)

1. Update `Info.plist` with Facebook configuration values
+ `FacebookAppID -> {your-app-id}` (put Facebook App Id)
Expand Down
749 changes: 0 additions & 749 deletions TwitterAuth/FirebaseTwitterAuthUI.xcodeproj/project.pbxproj

This file was deleted.

28 changes: 0 additions & 28 deletions TwitterAuth/FirebaseTwitterAuthUI/FUITwitterAuth.h

This file was deleted.

160 changes: 0 additions & 160 deletions TwitterAuth/FirebaseTwitterAuthUI/FUITwitterAuth.m

This file was deleted.

27 changes: 0 additions & 27 deletions TwitterAuth/FirebaseTwitterAuthUI/FirebaseTwitterAuthUI.h

This file was deleted.

26 changes: 0 additions & 26 deletions TwitterAuth/FirebaseTwitterAuthUI/Info.plist

This file was deleted.

Binary file not shown.
Binary file not shown.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading