Skip to content

Missing translations for signing in with email and password #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbahamon opened this issue Sep 11, 2017 · 4 comments
Closed

Missing translations for signing in with email and password #901

jbahamon opened this issue Sep 11, 2017 · 4 comments

Comments

@jbahamon
Copy link

jbahamon commented Sep 11, 2017

  • Android device: Motorola G5 Plus
  • Android OS version: 7.0
  • Google Play Services version: 11.5.09
  • FirebaseUI version: 2.2.0

Using a device with Spanish (Chile) as the only language.

Steps to reproduce:

  1. Login using an email account
  2. Enter an existing email account
  3. Provide an incorrect password
  4. Press on the "Sign in" ("Acceder", in Spanish) button
  • The error text shows "The password is invalid or the user does not have a password." instead of translated text.

This might happen because the exception/error received in WelcomeBackPasswordPrompt is not localized, only showing the (non-localized) description from a FirebaseAuthError.

Additionally, the accesibility info for the password visibility toggling item (the eye icon) from the password TextView is not localized. This can probably be solved by setting the app:passwordToggleContentDescription field on the password element in fui_register_email_layout.xml.

@jbahamon jbahamon changed the title Trying to sign in with a valid email and a wrong passwords shows a non-localized error message Trying to sign in with a valid email and a wrong password shows a non-localized error message Sep 11, 2017
@jbahamon jbahamon changed the title Trying to sign in with a valid email and a wrong password shows a non-localized error message Missing translations for signing in with email and password Sep 11, 2017
@samtstern
Copy link
Contributor

@jbahamon thanks for reporting this. This is probably a server error message that we are displaying directly, which is a bad idea. And we also appreciate the note about accesibility!

@SUPERCILEX
Copy link
Collaborator

@samtstern Doesn't #946 fix this?

@jstimes
Copy link
Contributor

jstimes commented Oct 5, 2017

@SUPERCILEX It seems like it would, but that method does not localize the server error messages, which is what this message is. We should log these server errors and have our own (localized) strings to show the user. I can work on this.

@samtstern samtstern added this to the 3.2.2 milestone Feb 21, 2018
@samtstern
Copy link
Contributor

This has been fixed and released in version 3.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants