Translate errors #1163
Merged
Translate errors #1163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ie03319754f361ce1fc5b1af7436671d4310965d0
|
I have kicked off the internal translation process for the new ones. |
SUPERCILEX
reviewed
Feb 21, 2018
| @@ -75,6 +75,10 @@ | |||
| <string name="fui_progress_dialog_sending" translation_description="Progress dialog while password recovery email is being sent">Sending…</string> | |||
| <string name="fui_error_email_does_not_exist" translation_description="Inline error when user attempt signin with invalid account">That email address doesn\'t match an existing account</string> | |||
|
|
|||
| <!-- Other error messages --> | |||
| <string name="fui_error_unknown" translation_description="General error messages for an unknown failure.">An unknown error occurred.</string> | |||
There was a problem hiding this comment.
Not sure if this is intentional or not, but we already have a very similar string:
<string name="fui_general_error" translation_description="Toast text flashing general error">An error has occurred.</string>There was a problem hiding this comment.
True. I will remove that one, I like it with 'unknown'
Change-Id: Idbdf402da3fefb2c59eb7a54b12c68e6c7b16a2a
Change-Id: I0321a282f22ed9e8a25be82e207cb75dd73681cd
Change-Id: If832245eeacca6b0bb202cad0bb0d59918c55bde
|
Ok so it looks like our translation system decided to remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #901