Skip to content

Localizing verification messages #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2017
Merged

Localizing verification messages #946

merged 2 commits into from
Oct 5, 2017

Conversation

jstimes
Copy link
Contributor

@jstimes jstimes commented Oct 5, 2017

This change will localize SMS & email verification messages to match the Locale currently in use on the user's device. iOS and Web are adding this as well.

@jstimes jstimes requested a review from samtstern October 5, 2017 17:05
@samtstern samtstern merged commit 15d839d into firebase:version-3.0.1-dev Oct 5, 2017
@samtstern samtstern added this to the 3.0.1 milestone Oct 5, 2017
Copy link
Contributor

@isaisachen isaisachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be simplified by calling mAuth.useAppLanguage()

@SUPERCILEX
Copy link
Collaborator

@isaisachen See #950

@isaisachen
Copy link
Contributor

Thanks @SUPERCILEX !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants