Added main ToS/PP #1300

lsirac · 2018-05-11T22:18:12Z

Changes toward GDPR compliance (#1245)

Still need to add a ToS/Pp footer nearly everywhere.

samtstern · 2018-05-11T22:31:56Z

@SUPERCILEX FYI: @lsirac is a new member of the Firebase Auth team and is going to be helping out on FirebaseUI, changing the ToS/PP flow to be compliant is his first task.

samtstern

Mostly looks good! Some comments,

samtstern · 2018-05-11T22:43:15Z

auth/src/main/java/com/firebase/ui/auth/ui/email/CheckEmailFragment.java

@@ -175,4 +181,14 @@ private void validateAndProceed() {
            mHandler.fetchProvider(email);
        }
    }
+
+    private void setUpTermsOfService(View view) {


I think this would be clearer if it accepted a TextView argument and the TextView was located by onViewCreated

samtstern · 2018-05-11T22:44:17Z

auth/src/main/res/layout/fui_check_email_layout.xml

@@ -28,6 +28,14 @@

        </android.support.design.widget.TextInputLayout>

+        <TextView


If you add something like tools:text="Terms and stuff" it will be visible in the design editor, which makes things easier.

samtstern · 2018-05-11T22:46:19Z

auth/src/main/res/layout/fui_check_email_layout.xml

@@ -28,6 +28,14 @@

        </android.support.design.widget.TextInputLayout>

+        <TextView
+            android:id="@+id/email_tos_and_pp_text"
+            style="@style/FirebaseUI.Text.BodyText"


We should get someone (is jnease still on the team?) to pick a better font size / color for this. It's too dark and too big IMO but I am pretty design challenged.

Also I think we may want this below the NEXT button but, again, I'd like a second opinion.

samtstern · 2018-05-11T22:47:42Z

auth/src/main/java/com/firebase/ui/auth/ui/email/CheckEmailFragment.java

+
+    private void setUpTermsOfService(View view) {
+        List<AuthUI.IdpConfig> providers = getFlowParams().providerInfo;
+        if (providers.size() == 1) {


Maybe add a convenience method to FlowParams that does this logic for you since we'll need it in a few places? Something like flowParams.isSingleProviderFlow()?

samtstern · 2018-05-11T22:48:12Z

auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailFragment.java

@@ -173,6 +169,18 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat
        }
    }

+    private @StringRes int getTermsStringResource() {


This method is unused. Did you mean to use or remove it?

samtstern · 2018-05-11T23:30:45Z

auth/src/main/java/com/firebase/ui/auth/util/ui/PreambleHandler.java

@@ -55,8 +74,9 @@ private void setPreamble(TextView textView) {
        textView.setText(mBuilder);
    }

-    private void setupCreateAccountPreamble() {
-        String withTargets = getPreambleStringWithTargets();
+    private void setupPreamble(@StringRes int textViewText) {


nit: don't really like this method name because setupPreamble and setPreamble are so similar.

samtstern · 2018-05-11T23:39:13Z

auth/src/main/res/values/strings.xml

@@ -5,6 +5,8 @@
    <string name="fui_default_toolbar_title" translatable="false">@string/app_name</string>
    <string name="fui_progress_dialog_loading" translation_description="Loading text in dialog">Loading…</string>
    <string name="fui_sign_in_default" translation_description="Button text to sign in">Sign in</string>
+    <string name="fui_tos_and_pp" translation_description="Global ToS and Privacy policy message">By continuing, you are indicating that you accept our <xliff:g example="https://google.com/terms" id="tos" translation_description="">%1$s</xliff:g> and <xliff:g example="https://google.com/privacy" id="pp" translation_description="">%2$s</xliff:g>.</string>


If you think this text is final let me know and I will ship them off for translation.

samtstern · 2018-05-11T23:43:58Z

Some images, for easy commenting:

NASCAR

Check Email

Phone Auth, Long

Phone Auth, Short

…samsterns feedback

SUPERCILEX

Awesome sauce, hi @lsirac 👋! Some style comments, questions about edge cases, and general feedback. Enjoy and welcome to the team! 🤗 (That was supposed to be a hug emoji... 😕😂)

PS: do you mind sharing your name? (I'm guessing it's not "Lsirac" 😉)

SUPERCILEX · 2018-05-15T01:20:51Z

auth/src/main/java/com/firebase/ui/auth/data/model/FlowParameters.java

@@ -128,4 +131,24 @@ public FlowParameters createFromParcel(Parcel in) {
            return new FlowParameters[size];
        }
    };
+
+    public boolean isSingleProviderFlow() {


Can you use this in SignInKickstarter too? I like your method much better.

SUPERCILEX · 2018-05-15T01:24:29Z

auth/src/main/java/com/firebase/ui/auth/data/model/FlowParameters.java

+    public @StringRes int getGlobalTermsStringResource() {
+        boolean hasTos = !TextUtils.isEmpty(termsOfServiceUrl);
+        boolean hasPp = !TextUtils.isEmpty(privacyPolicyUrl);
+        if(hasTos && hasPp) {


Can you run Ctrl + Alt + L to auto-format this file? I died a little inside seeing if(. 😁

Edit: Actually, I had a bunch of other style concerns so I've just created a patch to minimize the noise. Key takeaways:

Whitespace matters ⬜️🌌

There's nothing wrong with your annotation style, but our convention is to have them above the method

If there's copypasta code, you're probably doing something wrong 😉. Take a look at how I got rid of your new PreambleHandler constructor and made the setup overload act as a utility for the actual implementation instead of duplicating it.

Consistency above all else: I'm usually a little nitpicky (sorry! 😊), but all I really care about is that new code is consistent with the rest of the codebase. Imagine trying to read a book that switches fonts every few sentences—the meaning of what you're reading would get lost in your brain going "Wait, whaaaat?" Or at least, that's what happens with me. 🤷‍♂️

I've been spoiled by auto formatting, sorry! Thank you for your comments, it is much appreciated.

SUPERCILEX · 2018-05-15T02:10:56Z

auth/src/main/java/com/firebase/ui/auth/data/model/FlowParameters.java

+        } else if(hasTos) {
+            return R.string.fui_tos_only;
+        } else {
+            return R.string.fui_pp_only;


This else implies the default is the privacy policy—is that what you want? If so, we should add checks, update the README n' docs, throw exceptions, yada yada for AuthUI to ensure the developer must supply either a tos or a pp. Otherwise, we should return -1 and handle that case.

You're right, I'll change this. We won't force them to have a ToS/Privacy policy though.

SUPERCILEX · 2018-05-15T02:13:08Z

auth/src/main/java/com/firebase/ui/auth/data/model/FlowParameters.java

+    }
+
+    public @StringRes int getGlobalTermsFooterStringResource() {
+        return R.string.fui_tos_and_pp_footer;


Should this have if statements like above? If not, let's just inline it in the XML.

I added 2 more strings to deal with ToS only & Pp only. Having this makes more sense now :)

SUPERCILEX · 2018-05-15T02:15:52Z

auth/src/main/java/com/firebase/ui/auth/ui/email/EmailActivity.java

@@ -130,4 +134,14 @@ private void setSlideAnimation() {
        // Make the next activity slide in
        overridePendingTransition(R.anim.fui_slide_in_right, R.anim.fui_slide_out_left);
    }
+
+    private void setUpTermsOfServiceFooter() {


I'm seeing this method a lot. I wonder if it makes sense to add a PrivacyDisclosureUtils class that includes this and the tos methods you added in FlowParameters (I'm not a huge fan of logic in a POJO). @samtstern What do you think?

Seems like a good idea to me, less repetition is better!

SUPERCILEX · 2018-05-15T02:17:19Z

auth/src/main/java/com/firebase/ui/auth/ui/phone/PhoneActivity.java

@@ -406,4 +409,14 @@ private SubmitConfirmationCodeFragment getSubmitConfirmationCodeFragment() {
        return (SubmitConfirmationCodeFragment) getSupportFragmentManager().findFragmentByTag
                (SubmitConfirmationCodeFragment.TAG);
    }
+
+    private void setUpTermsOfServiceFooter() {


Yeah, I'm definitely thinking we need a utility, this is numeros quatros I've seen. 😆

SUPERCILEX · 2018-05-15T02:19:54Z

auth/src/main/res/layout-land/fui_auth_method_picker_layout.xml

@@ -32,6 +32,16 @@
            android:id="@+id/btn_holder"
            style="@style/FirebaseUI.AuthMethodPicker.ButtonHolder" />

+        <TextView


I believe you meant to put this out of the scroll view, right? If not, you can't put more than one view in a ScrollView so we'll need a LL.

SUPERCILEX · 2018-05-15T02:20:26Z

auth/src/main/res/layout/fui_activity_register_email.xml

+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_marginTop="@dimen/fui_field_padding_vert"
+        android:layout_gravity="bottom|right"


Let's use end instead of right.

SUPERCILEX · 2018-05-15T02:21:57Z

auth/src/main/res/layout/fui_auth_method_picker_layout.xml

+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_marginTop="@dimen/fui_field_padding_vert"
+        android:textColor="?android:textColorTertiary"


Does the color change if you remove this? Either way, we need to use some AppCompat version, not the system one. I'll get back to you if the color is wrong when you remove it.

My comment above addresses this I think.

Changed it to attr/textColorTertiary

SUPERCILEX · 2018-05-15T02:26:03Z

auth/src/main/res/values/strings.xml

@@ -100,4 +105,8 @@
    <string name="fui_verify_phone_number" translation_description="Button text to submit confirmation code and complete phone verification">Verify Phone Number</string>
    <string name="fui_continue_phone_login" translation_description="Button text to submit phone number and send sms">Continue</string>
    <string name="fui_sms_terms_of_service" translation_description="Fine print warning displayed below Verify Phone Number button">By tapping “%1$s”, an SMS may be sent. Message &amp; data rates may apply.</string>
+    <string name="fui_sms_terms_of_service_and_privacy_policy_extended" translation_description="Fine print warning displayed below Verify Phone Number button">By tapping “%1$s”, you are indicating that you accept our <xliff:g example="https://google.com/terms" id="tos" translation_description="">%2$s</xliff:g> and <xliff:g example="https://google.com/privacy" id="pp" translation_description="">%3$s</xliff:g>. An SMS may be sent. Message &amp; data rates may apply.</string>


We're going to need to kill fui_create_account_preamble_tos_and_pp and the others to make lint happy. In the meantime, add 'MissingTranslation' // TODO remove in future PR here and then @samtstern will probably have you create a second PR that kills those strings.

Sent off the strings for translation.

samtstern · 2018-05-15T20:36:39Z

auth/src/main/res/values/strings.xml

@@ -5,6 +5,11 @@
    <string name="fui_default_toolbar_title" translatable="false">@string/app_name</string>
    <string name="fui_progress_dialog_loading" translation_description="Loading text in dialog">Loading…</string>
    <string name="fui_sign_in_default" translation_description="Button text to sign in">Sign in</string>
+    <string name="fui_tos_and_pp" translation_description="Global ToS and Privacy policy message">By continuing, you are indicating that you accept our <xliff:g example="https://google.com/terms" id="tos" translation_description="">%1$s</xliff:g> and <xliff:g example="https://google.com/privacy" id="pp" translation_description="">%2$s</xliff:g>.</string>


Also make sure you add some translation_description that's not ""

lsirac · 2018-05-15T23:08:22Z

auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailFragment.java

-                            .setPhotoUri(mUser.getPhotoUri())
-                            .build())
-                    .build(),
+                            new User.Builder(EmailAuthProvider.PROVIDER_ID, email)


Is something wrong with the formatting settings?

I wouldn't worry about this. Equally legible either way.

Nope, we just made an indentation change to the styling a long time ago and never bothered running it over the whole codebase. Like @samtstern said, we're not that nit picky. 😆 Thanks for checking though! 👍

I'll take another look at this tomorrow.

SUPERCILEX · 2018-05-15T23:35:53Z

library/quality/quality.gradle

@@ -77,6 +77,7 @@ android {
                'IconExpectedSize',
                'InvalidPackage', // Firestore uses GRPC which makes lint mad
                'NewerVersionAvailable', 'GradleDependency' // For reproducible builds
+                'MissingTranslation' // TODO remove in future PR


I think you're also going to have to add UnusedResources. And you need a comma above. 😄

Done, thanks!

samtstern

Looking great! Almost all of my comments are about style or clarity and are very minor.

samtstern · 2018-05-15T23:40:36Z

auth/src/main/java/com/firebase/ui/auth/ui/email/CheckEmailFragment.java

@@ -96,6 +99,19 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat
        }

        view.findViewById(R.id.button_next).setOnClickListener(this);
+
+        TextView termsText = view.<TextView>findViewById(R.id.email_tos_and_pp_text);


optional style nit:

I normally see this:

TextView termsText = (TextView) view.findViewById(R.id.email_tos_and_pp_text);

Not this:

TextView termsText = view.<TextView>findViewById(R.id.email_tos_and_pp_text);

Oh yeah, I forgot to mention something else about this. You don't need those casts! Notice how the IDE greys them out? That's cuz findViewById was updated to use generics in API 26.

samtstern · 2018-05-15T23:42:36Z

auth/src/main/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivity.java

@@ -106,6 +108,11 @@ protected void onFailure(@NonNull Exception e) {
                }
            }
        });
+
+        TextView termsText = findViewById(R.id.main_tos_and_pp);
+        PrivacyDisclosureUtils.setupTermsOfServiceAndPrivacyPolicyText(AuthMethodPickerActivity.this,


nit: do you need AuthMethodPickerActivity.this or could it be just this?

I'll change to this

samtstern · 2018-05-15T23:43:18Z

auth/src/main/java/com/firebase/ui/auth/ui/phone/SubmitConfirmationCodeFragment.java

-            Bundle savedInstanceState) {
+    public View onCreateView(@NonNull LayoutInflater inflater,
+                             @Nullable ViewGroup container,
+                             @Nullable


nit: formatter kinda nuked this one. Can we put the Bundle savedInstanceState back on the line with @Nullable?

samtstern · 2018-05-15T23:44:59Z

auth/src/main/java/com/firebase/ui/auth/ui/phone/VerifyPhoneNumberFragment.java

+                mSmsTermsText,
+                multipleProviderFlowText);
+
+        if (!flowParameters.isSingleProviderFlow()) {


So if this is a single provider flow then we'll have both the big text and the footer? If that's not the case (maybe the previous method has some internal switching) let's make that clearer here by doing if / else so only one of the PrivacyDisclosureUtils classes runs.

Yes, SMS is special because we warn them either way (about the SMS cost). I'll change this

samtstern · 2018-05-15T23:46:43Z

auth/src/main/java/com/firebase/ui/auth/util/data/PrivacyDisclosureUtils.java

+                footerText);
+    }
+
+    public static void setupTermsOfServiceAndPrivacyPolicySmsText(Context context,


Ok looking at this method I'd recommend a few things for code clarity:

Drop the last parameter here

Drop the if/else method in here

Where we call this method, do:

if (singleProvider) { PrivacyUtils.blah() } else { termsText.setText(multipleMessage) }

I think that's easier to read and more similar to how we use the non-SMS methods.

I agree. Changed it.

samtstern · 2018-05-15T23:50:39Z

auth/src/main/res/layout/fui_auth_method_picker_layout.xml

+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_marginTop="@dimen/fui_field_padding_vert"
+        android:textColor="?android:textColorTertiary"


My comment above addresses this I think.

samtstern · 2018-05-15T23:51:45Z

auth/src/main/res/layout/fui_auth_method_picker_layout.xml

+        android:textColor="?android:textColorTertiary"
+        android:textIsSelectable="false"
+        android:gravity="center"
+        app:layout_constraintTop_toBottomOf="@id/container"/>


Have you tested this with all numbers of buttons? IMO it would be more natural for this to be constrained Bottom_toBottomOf="parent" so it's always exactly on the bottom.

Also make sure it looks OK in landscape.

Done, I'll push these changes soon.

samtstern · 2018-05-15T23:52:49Z

auth/src/main/res/layout/fui_phone_layout.xml

+
+    </ScrollView>
+
+    <TextView


We repeat this a lot, we could extract most of the attributes into a style and then this would only be like a two-line copy paste (ID and style) into each layout instead of a ~10 line.

We'll do this in a different PR.

samtstern · 2018-05-15T23:53:12Z

auth/src/main/res/layout/fui_phone_layout.xml

+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:layout_marginTop="@dimen/fui_field_padding_vert"
+        android:paddingRight="15dp"


nit: 15 is a strange number, try 16 which is a standard Android padding amount (normally you work in multiples of 4dp)

samtstern · 2018-05-15T23:53:33Z

auth/src/main/res/values/strings.xml

@@ -100,4 +105,8 @@
    <string name="fui_verify_phone_number" translation_description="Button text to submit confirmation code and complete phone verification">Verify Phone Number</string>
    <string name="fui_continue_phone_login" translation_description="Button text to submit phone number and send sms">Continue</string>
    <string name="fui_sms_terms_of_service" translation_description="Fine print warning displayed below Verify Phone Number button">By tapping “%1$s”, an SMS may be sent. Message &amp; data rates may apply.</string>
+    <string name="fui_sms_terms_of_service_and_privacy_policy_extended" translation_description="Fine print warning displayed below Verify Phone Number button">By tapping “%1$s”, you are indicating that you accept our <xliff:g example="https://google.com/terms" id="tos" translation_description="">%2$s</xliff:g> and <xliff:g example="https://google.com/privacy" id="pp" translation_description="">%3$s</xliff:g>. An SMS may be sent. Message &amp; data rates may apply.</string>


Sent off the strings for translation.

samtstern · 2018-05-16T16:31:23Z

@lsirac we've got some new lint errors

Change-Id: Id996ce893941216beeb251be0b1fa2b076c220a2

SUPERCILEX

Just a few more nits. Besides those, LGTM!

PS: lint thinks you have some pointless FrameLayouts, dunno if that's true.

SUPERCILEX · 2018-05-16T23:58:39Z

auth/src/main/java/com/firebase/ui/auth/data/remote/SignInKickstarter.java

@@ -92,9 +92,8 @@ public void onComplete(@NonNull Task<CredentialRequestResponse> task) {

    private void startAuthMethodChoice() {
        List<AuthUI.IdpConfig> idpConfigs = getArguments().providerInfo;


Can we inline getArguments().providerInfo below? (Trick: use Ctrl + Shift + N)

Not sure what you mean. Ctrl + Shift + N lets me search for files.

I changed it so that there is no local idpConfigs list, we just do getArguments().providerInfo.get(0) instead. Is that what you meant?

Lol, my B. I meant Ctrl + Alt + N. 😊 You should try it, I'm always impressed.

But yeah, LGTM

SUPERCILEX · 2018-05-17T00:00:19Z

auth/src/main/java/com/firebase/ui/auth/ui/email/CheckEmailFragment.java

+
+        TextView termsText = view.findViewById(R.id.email_tos_and_pp_text);
+        TextView footerText = view.findViewById(R.id.email_footer_tos_and_pp_text);
+        FlowParameters flowParameters = getFlowParams();


Can we get rid of flowParameters? (It's just as long as getFlowParams() and is only used once.)

I changed it to pass flowParameters instead of making 2 more calls to getFlowParams() - unless you want me to change them all to getFlowParams()?

SUPERCILEX · 2018-05-17T00:02:49Z

auth/src/main/java/com/firebase/ui/auth/util/data/PrivacyDisclosureUtils.java

+
+    private static final int NO_TOS_OR_PP = -1;
+
+    public static void setupTermsOfServiceAndPrivacyPolicyText(Context context,


Wondering if we should shorten this to setupTosAndPp. Or at least, setupTermsOfServiceAndPrivacyPolicyText is quite a mouthful. 😆 @samtstern Thoughts?

I prefer to keep it like this 😊, do you both want me to change it? @samtstern

If you think that's clearer then SGTM 👍.

SUPERCILEX · 2018-05-17T00:03:51Z

auth/src/main/java/com/firebase/ui/auth/util/data/PrivacyDisclosureUtils.java

+        } else if (privacyPolicyUrlProvided) {
+            return R.string.fui_pp_footer;
+        }
+        return NO_TOS_OR_PP; // add constant


// add constant

Looks like you did that, comment no longer needed.

SUPERCILEX · 2018-05-17T00:04:17Z

auth/src/main/java/com/firebase/ui/auth/util/data/PrivacyDisclosureUtils.java

+    private static int getGlobalTermsStringResource(FlowParameters flowParameters) {
+        boolean termsOfServiceUrlProvided = flowParameters.isTermsOfServiceUrlProvided();
+        boolean privacyPolicyUrlProvided = flowParameters.isPrivacyPolicyUrlProvided();
+        if (termsOfServiceUrlProvided && privacyPolicyUrlProvided) {


Can we add a new line before and after the if/else here and in the other methods. Makes it more readable IMO.

SUPERCILEX · 2018-05-17T00:06:45Z

auth/src/main/res/layout/fui_check_email_layout.xml

+                android:textIsSelectable="false"
+                tools:text="Terms and Privacy Policy" />
+
+            <TextView


What's the difference between this TextView and the one above? If this isn't a mistake, we should add a comment explaining that.

SUPERCILEX · 2018-05-17T00:11:42Z

Oh hey, looks like @samtstern fixed them!

samtstern · 2018-05-17T00:17:49Z

@SUPERCILEX the layouts are pointless but they're gonna need to be there for my progress dialog thing anyway so just making my merge life easier.

samtstern

LGTM from me, just a few more comments from @SUPERCILEX

SUPERCILEX · 2018-05-17T00:48:33Z

Alrighty, waiting for you to push!

samtstern · 2018-05-17T01:11:47Z

Merged, welcome to the contributors list @lsirac!

Added main ToS/PP, WIP

dac52e6

lsirac requested a review from samtstern May 11, 2018 22:18

samtstern changed the title ~~Added main ToS/PP, WIP~~ [WIP] Added main ToS/PP May 11, 2018

samtstern added this to the 4.0.0 milestone May 11, 2018

samtstern reviewed May 11, 2018

View reviewed changes

Adds footer required for GDPR compliance. Also made changes based on …

f5b0b75

…samsterns feedback

lsirac force-pushed the GDPR-compliance branch from a4fde12 to f5b0b75 Compare May 15, 2018 00:36

SUPERCILEX reviewed May 15, 2018

View reviewed changes

samtstern reviewed May 15, 2018

View reviewed changes

Fixes footer ToS/Pp links. Also made changes based on review feedback.

420da68

lsirac force-pushed the GDPR-compliance branch from 325c2cf to 420da68 Compare May 15, 2018 23:04

lsirac commented May 15, 2018

View reviewed changes

SUPERCILEX reviewed May 15, 2018

View reviewed changes

samtstern reviewed May 15, 2018

View reviewed changes

samtstern changed the title ~~[WIP] Added main ToS/PP~~ Added main ToS/PP May 16, 2018

Minor fixes before merge

5793bd8

lsirac and others added 3 commits May 16, 2018 15:44

Fixes lint errors and auth method picker landscape issues.

670b363

Move ToS/PP into scrollviews (#1302)

21df8b3

Fix lint errors

3cedd37

Change-Id: Id996ce893941216beeb251be0b1fa2b076c220a2

SUPERCILEX reviewed May 17, 2018

View reviewed changes

samtstern approved these changes May 17, 2018

View reviewed changes

Applies code review suggestions

302c94c

SUPERCILEX approved these changes May 17, 2018

View reviewed changes

samtstern merged commit 6b740bc into version-4.0.0-dev May 17, 2018

lsirac deleted the GDPR-compliance branch May 17, 2018 17:57

		@@ -28,6 +28,14 @@

		</android.support.design.widget.TextInputLayout>

		<TextView

		@@ -92,9 +92,8 @@ public void onComplete(@NonNull Task<CredentialRequestResponse> task) {

		private void startAuthMethodChoice() {
		List<AuthUI.IdpConfig> idpConfigs = getArguments().providerInfo;


		private static final int NO_TOS_OR_PP = -1;

		public static void setupTermsOfServiceAndPrivacyPolicyText(Context context,

Added main ToS/PP #1300

Added main ToS/PP #1300

Conversation

lsirac commented May 11, 2018 • edited by samtstern Loading

samtstern commented May 11, 2018

samtstern left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samtstern commented May 11, 2018

SUPERCILEX left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samtstern left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lsirac May 16, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lsirac May 16, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samtstern commented May 16, 2018

SUPERCILEX left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lsirac May 17, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lsirac May 17, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lsirac commented May 11, 2018 •

edited by samtstern

Loading

lsirac May 16, 2018 •

edited

Loading

lsirac May 16, 2018 •

edited

Loading

lsirac May 17, 2018 •

edited

Loading

lsirac May 17, 2018 •

edited

Loading

lsirac May 17, 2018 •

edited

Loading