Fix 4.1.0 lint #1329
Merged
Fix 4.1.0 lint #1329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I1929e199d1676ae26e8e84fb528d8846a740b911
|
@SUPERCILEX now that |
SUPERCILEX
approved these changes
May 31, 2018
| @@ -79,7 +79,7 @@ protected void onFailure(@NonNull Exception e) { | |||
| protected void onSuccess(@NonNull PhoneVerification verification) { | |||
| if (verification.isAutoVerified()) { | |||
| Toast.makeText( | |||
| PhoneActivity.this, R.string.fui_verified, Toast.LENGTH_LONG).show(); | |||
| PhoneActivity.this, R.string.fui_auto_verified, Toast.LENGTH_LONG).show(); | |||
There was a problem hiding this comment.
Whoops, thanks for catching that! 😊
|
@samtstern right here: FirebaseUI-Android/build.gradle.kts Line 88 in fc9e46a FirebaseUI-Android/auth/build.gradle.kts Line 13 in fc9e46a |
|
Looks like lint didn't like your baseline changes. Would probably just be easier to move the lambda around. 🤷♂️ |
Merged
Change-Id: I2317eb13e18e5dd837f8cb45c146f16d4676b2d5
Change-Id: I531edc2b32679a9c73e519586f448aa9d63fab33
Change-Id: Ie4627aab27ebaf0f8e03100635e980c0a08e7d01
|
WHY DOES SQUASH AND MERGE NOT WORK |
|
|
|
Lol, report it? 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.