Skip to content

Fix 4.1.0 lint #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 6, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions auth/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ android {

lintOptions {
disable("UnusedQuantity")
disable("MissingTranslation") // TODO: Translate fui_auto_verified
}

testOptions {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ public interface Listener {
Set<String> whitelistedCountryIsos;
Set<String> blacklistedCountryIsos;

public CountryListLoadTask(Listener listener,
@Nullable List<String> whitelistedCountries,
@Nullable List<String> blacklistedCountries) {
public CountryListLoadTask(@Nullable List<String> whitelistedCountries,
@Nullable List<String> blacklistedCountries,
Listener listener) {
mListener = listener;

if (whitelistedCountries != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,8 @@ public void onClick(View view) {
}

private void loadCountryList() {
new CountryListLoadTask(this,
whitelistedCountries,
blacklistedCountries).executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
new CountryListLoadTask(whitelistedCountries, blacklistedCountries, this
).executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
}

private void executeUserClickListener(View view) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ protected void onFailure(@NonNull Exception e) {
protected void onSuccess(@NonNull PhoneVerification verification) {
if (verification.isAutoVerified()) {
Toast.makeText(
PhoneActivity.this, R.string.fui_verified, Toast.LENGTH_LONG).show();
PhoneActivity.this, R.string.fui_auto_verified, Toast.LENGTH_LONG).show();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, thanks for catching that! 😊

}

handler.startSignIn(verification.getCredential(), new IdpResponse.Builder(
Expand Down
6 changes: 0 additions & 6 deletions auth/src/main/res/values-ar/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,11 @@
<string name="fui_resend_code_in">إعادة إرسال الرمز بعد 0:%02d</string>
<string name="fui_verify_your_phone_title">إثبات ملكية رقم هاتفك</string>
<string name="fui_verifying">جارٍ التحقق…</string>
<string name="fui_retrieving_sms">جارٍ استرداد الرسائل القصيرة SMS…</string>
<string name="fui_incorrect_code_dialog_body">الرمز غير صحيح. يُرجى المحاولة مجددًا.</string>
<string name="fui_incorrect_code_dialog_positive_button_text">موافق</string>
<string name="fui_error_too_many_attempts">تم استخدام رقم الهاتف هذا لعدد كبير جدًا من المرات</string>
<string name="fui_error_quota_exceeded">حدثت مشكلة أثناء إثبات ملكية رقم هاتفك</string>
<string name="fui_error_session_expired">لم يعد هذا الرمز صالحًا</string>
<string name="fui_sign_in_with_phone_number">تسجيل الدخول عبر رقم الهاتف</string>
<string name="fui_done">تم</string>
<string name="fui_verified">اكتملت عملية إثبات الملكية!</string>
<string name="fui_code_sent">تم إرسال الرمز!</string>
<string name="fui_resending">جارٍ إعادة الإرسال…</string>
<string name="fui_resend_code">إعادة إرسال الرمز</string>
<string name="fui_verify_phone_number">تأكيد ملكية رقم الهاتف</string>
<string name="fui_continue_phone_login">متابعة</string>
Expand Down
6 changes: 0 additions & 6 deletions auth/src/main/res/values-b+es+419/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,11 @@
<string name="fui_resend_code_in">Se reenviará el código en 0:%02d</string>
<string name="fui_verify_your_phone_title">Verifica tu número de teléfono</string>
<string name="fui_verifying">Verificando…</string>
<string name="fui_retrieving_sms">Recuperando SMS…</string>
<string name="fui_incorrect_code_dialog_body">Código incorrecto. Vuelve a intentarlo.</string>
<string name="fui_incorrect_code_dialog_positive_button_text">Aceptar</string>
<string name="fui_error_too_many_attempts">Este número de teléfono se usó demasiadas veces</string>
<string name="fui_error_quota_exceeded">Ocurrió un problema durante la verificación de tu número de teléfono</string>
<string name="fui_error_session_expired">Este código ya no es válido</string>
<string name="fui_sign_in_with_phone_number">Acceder con el número de teléfono</string>
<string name="fui_done">Listo</string>
<string name="fui_verified">¡Verificado!</string>
<string name="fui_code_sent">Se envió el código.</string>
<string name="fui_resending">Reenviando…</string>
<string name="fui_resend_code">Reenviar código</string>
<string name="fui_verify_phone_number">Verificar número de teléfono</string>
<string name="fui_continue_phone_login">Continuar</string>
Expand Down
6 changes: 0 additions & 6 deletions auth/src/main/res/values-bg/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,11 @@
<string name="fui_resend_code_in">Повторно изпращане на кода след 0:%02d</string>
<string name="fui_verify_your_phone_title">Потвърждаване на телефонния ви номер</string>
<string name="fui_verifying">Потвърждава се…</string>
<string name="fui_retrieving_sms">SMS съобщението се извлича…</string>
<string name="fui_incorrect_code_dialog_body">Неправилен код. Опитайте отново.</string>
<string name="fui_incorrect_code_dialog_positive_button_text">ОК</string>
<string name="fui_error_too_many_attempts">Този телефонен номер е използван твърде много пъти</string>
<string name="fui_error_quota_exceeded">При потвърждаването на телефонния ви номер възникна проблем</string>
<string name="fui_error_session_expired">Този код вече не е валиден</string>
<string name="fui_sign_in_with_phone_number">Вход с телефонен номер</string>
<string name="fui_done">Готово</string>
<string name="fui_verified">Потвърдено!</string>
<string name="fui_code_sent">Кодът е изпратен!</string>
<string name="fui_resending">Изпраща се повторно…</string>
<string name="fui_resend_code">Повторно изпращане на кода</string>
<string name="fui_verify_phone_number">Потвърждаване на телефонния номер</string>
<string name="fui_continue_phone_login">Напред</string>
Expand Down
6 changes: 0 additions & 6 deletions auth/src/main/res/values-bn/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,11 @@
<string name="fui_resend_code_in">0:%02d এ কোডটি আবার পাঠান</string>
<string name="fui_verify_your_phone_title">আপনার ফোন নম্বর যাচাই করুন</string>
<string name="fui_verifying">যাচাই করা হচ্ছে…</string>
<string name="fui_retrieving_sms">এসএমএসটি পুনরুদ্ধার করা হচ্ছে…</string>
<string name="fui_incorrect_code_dialog_body">কোডটি ভুল। আবার চেষ্টা করুন।</string>
<string name="fui_incorrect_code_dialog_positive_button_text">ঠিক আছে</string>
<string name="fui_error_too_many_attempts">এই ফোন নম্বরটি অনেকবার ব্যবহার করা হয়েছে</string>
<string name="fui_error_quota_exceeded">আপনার ফোন নম্বরটি যাচাই করতে সমস্যা হয়েছে</string>
<string name="fui_error_session_expired">এই কোডটি আর ব্যবহার করা যাবে না</string>
<string name="fui_sign_in_with_phone_number">ফোন নম্বর দিয়ে সাইন-ইন করুন</string>
<string name="fui_done">সম্পন্ন হয়েছে</string>
<string name="fui_verified">যাচাই করা হয়েছে!</string>
<string name="fui_code_sent">কোডটি পাঠানো হয়েছে!</string>
<string name="fui_resending">আবার পাঠানো হচ্ছে…</string>
<string name="fui_resend_code">কোডটি আবার পাঠান</string>
<string name="fui_verify_phone_number">ফোন নম্বর যাচাই করুন</string>
<string name="fui_continue_phone_login">চালিয়ে যান</string>
Expand Down
6 changes: 0 additions & 6 deletions auth/src/main/res/values-ca/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,11 @@
<string name="fui_resend_code_in">Torna a enviar el codi d\'aquí a 0:%02d</string>
<string name="fui_verify_your_phone_title">Verifica el número de telèfon</string>
<string name="fui_verifying">S\'està verificant…</string>
<string name="fui_retrieving_sms">S\'està recuperant l\'SMS…</string>
<string name="fui_incorrect_code_dialog_body">El codi no és correcte. Torna-ho a provar.</string>
<string name="fui_incorrect_code_dialog_positive_button_text">D\'acord</string>
<string name="fui_error_too_many_attempts">Aquest número de telèfon s\'ha utilitzat massa vegades</string>
<string name="fui_error_quota_exceeded">Hi ha hagut un problema en verificar el número de telèfon</string>
<string name="fui_error_session_expired">Aquest codi ja no és vàlid</string>
<string name="fui_sign_in_with_phone_number">Inicia la sessió amb el número de telèfon</string>
<string name="fui_done">Fet</string>
<string name="fui_verified">S\'ha verificat.</string>
<string name="fui_code_sent">S\'ha enviat el codi.</string>
<string name="fui_resending">S\'està tornant a enviar…</string>
<string name="fui_resend_code">Torna a enviar el codi</string>
<string name="fui_verify_phone_number">Verifica el número de telèfon</string>
<string name="fui_continue_phone_login">Continua</string>
Expand Down
6 changes: 0 additions & 6 deletions auth/src/main/res/values-cs/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,11 @@
<string name="fui_resend_code_in">Znovu zaslat kód za 0:%02d</string>
<string name="fui_verify_your_phone_title">Ověřit telefonní číslo</string>
<string name="fui_verifying">Ověřování…</string>
<string name="fui_retrieving_sms">Načítání SMS…</string>
<string name="fui_incorrect_code_dialog_body">Špatný kód. Zkuste to znovu.</string>
<string name="fui_incorrect_code_dialog_positive_button_text">V pořádku</string>
<string name="fui_error_too_many_attempts">Toto telefonní číslo již bylo použito příliš mnohokrát</string>
<string name="fui_error_quota_exceeded">Při ověřování vašeho telefonního čísla došlo k potížím</string>
<string name="fui_error_session_expired">Platnost kódu vypršela</string>
<string name="fui_sign_in_with_phone_number">Přihlášení pomocí telefonního čísla</string>
<string name="fui_done">Hotovo</string>
<string name="fui_verified">Ověřeno!</string>
<string name="fui_code_sent">Kód odeslán!</string>
<string name="fui_resending">Opakované odesílání…</string>
<string name="fui_resend_code">Znovu poslat kód</string>
<string name="fui_verify_phone_number">Ověřit telefonní číslo</string>
<string name="fui_continue_phone_login">Pokračovat</string>
Expand Down
6 changes: 0 additions & 6 deletions auth/src/main/res/values-da/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,11 @@
<string name="fui_resend_code_in">Send koden igen om 0:%02d</string>
<string name="fui_verify_your_phone_title">Bekræft dit telefonnummer</string>
<string name="fui_verifying">Bekræfter…</string>
<string name="fui_retrieving_sms">Henter sms…</string>
<string name="fui_incorrect_code_dialog_body">Koden er forkert. Prøv igen.</string>
<string name="fui_incorrect_code_dialog_positive_button_text">OK</string>
<string name="fui_error_too_many_attempts">Dette telefonnummer er blevet brugt for mange gange</string>
<string name="fui_error_quota_exceeded">Dit telefonnummer kunne ikke bekræftes</string>
<string name="fui_error_session_expired">Denne kode er ikke længere gyldig</string>
<string name="fui_sign_in_with_phone_number">Log ind med telefonnummer</string>
<string name="fui_done">Udført</string>
<string name="fui_verified">Bekræftet!</string>
<string name="fui_code_sent">Kode sendt.</string>
<string name="fui_resending">Sender igen…</string>
<string name="fui_resend_code">Send koden igen</string>
<string name="fui_verify_phone_number">Bekræft telefonnummer</string>
<string name="fui_continue_phone_login">Fortsæt</string>
Expand Down
6 changes: 0 additions & 6 deletions auth/src/main/res/values-de-rAT/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,11 @@
<string name="fui_resend_code_in">Code in 0:%02d erneut senden</string>
<string name="fui_verify_your_phone_title">Telefonnummer bestätigen</string>
<string name="fui_verifying">Wird verifiziert…</string>
<string name="fui_retrieving_sms">SMS werden abgerufen…</string>
<string name="fui_incorrect_code_dialog_body">Falscher Code. Versuchen Sie es noch einmal.</string>
<string name="fui_incorrect_code_dialog_positive_button_text">OK</string>
<string name="fui_error_too_many_attempts">Diese Telefonnummer wurde schon zu oft verwendet</string>
<string name="fui_error_quota_exceeded">Bei der Bestätigung Ihrer Telefonnummer ist ein Problem aufgetreten</string>
<string name="fui_error_session_expired">Dieser Code ist nicht mehr gültig</string>
<string name="fui_sign_in_with_phone_number">Mit einer Telefonnummer anmelden</string>
<string name="fui_done">Fertig</string>
<string name="fui_verified">Bestätigt</string>
<string name="fui_code_sent">Code gesendet</string>
<string name="fui_resending">Wird erneut gesendet…</string>
<string name="fui_resend_code">Code erneut senden</string>
<string name="fui_verify_phone_number">Telefonnummer bestätigen</string>
<string name="fui_continue_phone_login">Weiter</string>
Expand Down
6 changes: 0 additions & 6 deletions auth/src/main/res/values-de-rCH/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,11 @@
<string name="fui_resend_code_in">Code in 0:%02d erneut senden</string>
<string name="fui_verify_your_phone_title">Telefonnummer bestätigen</string>
<string name="fui_verifying">Wird verifiziert…</string>
<string name="fui_retrieving_sms">SMS werden abgerufen…</string>
<string name="fui_incorrect_code_dialog_body">Falscher Code. Versuchen Sie es noch einmal.</string>
<string name="fui_incorrect_code_dialog_positive_button_text">OK</string>
<string name="fui_error_too_many_attempts">Diese Telefonnummer wurde schon zu oft verwendet</string>
<string name="fui_error_quota_exceeded">Bei der Bestätigung Ihrer Telefonnummer ist ein Problem aufgetreten</string>
<string name="fui_error_session_expired">Dieser Code ist nicht mehr gültig</string>
<string name="fui_sign_in_with_phone_number">Mit einer Telefonnummer anmelden</string>
<string name="fui_done">Fertig</string>
<string name="fui_verified">Bestätigt</string>
<string name="fui_code_sent">Code gesendet</string>
<string name="fui_resending">Wird erneut gesendet…</string>
<string name="fui_resend_code">Code erneut senden</string>
<string name="fui_verify_phone_number">Telefonnummer bestätigen</string>
<string name="fui_continue_phone_login">Weiter</string>
Expand Down
6 changes: 0 additions & 6 deletions auth/src/main/res/values-de/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,11 @@
<string name="fui_resend_code_in">Code in 0:%02d erneut senden</string>
<string name="fui_verify_your_phone_title">Telefonnummer bestätigen</string>
<string name="fui_verifying">Wird verifiziert…</string>
<string name="fui_retrieving_sms">SMS werden abgerufen…</string>
<string name="fui_incorrect_code_dialog_body">Falscher Code. Versuchen Sie es noch einmal.</string>
<string name="fui_incorrect_code_dialog_positive_button_text">OK</string>
<string name="fui_error_too_many_attempts">Diese Telefonnummer wurde schon zu oft verwendet</string>
<string name="fui_error_quota_exceeded">Bei der Bestätigung Ihrer Telefonnummer ist ein Problem aufgetreten</string>
<string name="fui_error_session_expired">Dieser Code ist nicht mehr gültig</string>
<string name="fui_sign_in_with_phone_number">Mit einer Telefonnummer anmelden</string>
<string name="fui_done">Fertig</string>
<string name="fui_verified">Bestätigt</string>
<string name="fui_code_sent">Code gesendet</string>
<string name="fui_resending">Wird erneut gesendet…</string>
<string name="fui_resend_code">Code erneut senden</string>
<string name="fui_verify_phone_number">Telefonnummer bestätigen</string>
<string name="fui_continue_phone_login">Weiter</string>
Expand Down
6 changes: 0 additions & 6 deletions auth/src/main/res/values-el/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,11 @@
<string name="fui_resend_code_in">Επανάληψη αποστολής κωδικού σε 0:%02d</string>
<string name="fui_verify_your_phone_title">Επαλήθευση του τηλεφώνου σας</string>
<string name="fui_verifying">Επαλήθευση…</string>
<string name="fui_retrieving_sms">Γίνεται ανάκτηση SMS…</string>
<string name="fui_incorrect_code_dialog_body">Εσφαλμένος κωδικός. Δοκιμάστε ξανά.</string>
<string name="fui_incorrect_code_dialog_positive_button_text">ΟΚ</string>
<string name="fui_error_too_many_attempts">Αυτός ο αριθμός τηλεφώνου χρησιμοποιήθηκε πάρα πολλές φορές</string>
<string name="fui_error_quota_exceeded">Παρουσιάστηκε πρόβλημα με την επαλήθευση του αριθμού τηλεφώνου</string>
<string name="fui_error_session_expired">Αυτός ο κωδικός δεν είναι πλέον έγκυρος</string>
<string name="fui_sign_in_with_phone_number">Σύνδεση με αριθμό τηλεφώνου</string>
<string name="fui_done">Τέλος</string>
<string name="fui_verified">Επαληθεύτηκε!</string>
<string name="fui_code_sent">Ο κωδικός στάλθηκε!</string>
<string name="fui_resending">Επανάληψη αποστολής…</string>
<string name="fui_resend_code">Επανάληψη αποστολής κωδικού</string>
<string name="fui_verify_phone_number">Επαλήθευση αριθμού τηλεφώνου</string>
<string name="fui_continue_phone_login">Συνέχεια</string>
Expand Down
6 changes: 0 additions & 6 deletions auth/src/main/res/values-en-rAU/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,11 @@
<string name="fui_resend_code_in">Resend code in 0:%02d</string>
<string name="fui_verify_your_phone_title">Verify your phone number</string>
<string name="fui_verifying">Verifying…</string>
<string name="fui_retrieving_sms">Retrieving SMS…</string>
<string name="fui_incorrect_code_dialog_body">Wrong code. Try again.</string>
<string name="fui_incorrect_code_dialog_positive_button_text">OK</string>
<string name="fui_error_too_many_attempts">This phone number has been used too many times</string>
<string name="fui_error_quota_exceeded">There was a problem verifying your phone number</string>
<string name="fui_error_session_expired">This code is no longer valid</string>
<string name="fui_sign_in_with_phone_number">Sign in with phone number</string>
<string name="fui_done">Done</string>
<string name="fui_verified">Verified.</string>
<string name="fui_code_sent">Code sent.</string>
<string name="fui_resending">Resending…</string>
<string name="fui_resend_code">Resend code</string>
<string name="fui_verify_phone_number">Verify Phone Number</string>
<string name="fui_continue_phone_login">Continue</string>
Expand Down
Loading