Skip to content

fix : fix wrong colors in AuthUI EditText with NightMode #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 9, 2017
Merged

fix : fix wrong colors in AuthUI EditText with NightMode #504

merged 3 commits into from
Jan 9, 2017

Conversation

the-dagger
Copy link
Contributor

Fixes #502 and #503

@the-dagger the-dagger mentioned this pull request Jan 9, 2017
Closed
@samtstern
Copy link
Contributor

@the-dagger the build is failing with this PR:

:auth:processReleaseResources/home/travis/build/firebase/FirebaseUI-Android/auth/build/intermediates/res/merged/release/values-v21/values-v21.xml:260:21-42: AAPT: Resource entry FirebaseUI.EditText already has bag item android:textColorHint.
    
/home/travis/build/firebase/FirebaseUI-Android/auth/build/intermediates/res/merged/release/values-v21/values-v21.xml:259:9-68: AAPT: Originally defined here.
    
/home/travis/build/firebase/FirebaseUI-Android/auth/build/intermediates/res/merged/release/values-v21/values-v21.xml:260: error: Resource entry FirebaseUI.EditText already has bag item android:textColorHint.
/home/travis/build/firebase/FirebaseUI-Android/auth/build/intermediates/res/merged/release/values-v21/values-v21.xml:259: Originally defined here.

@the-dagger
Copy link
Contributor Author

Sorry, my bad.
Accidentally messed up attributes while copying.
Please squash the commits if the CI test passes.
Cheers.

@samtstern samtstern merged commit 97ac613 into firebase:version-1.1.0-dev Jan 9, 2017
@samtstern
Copy link
Contributor

@the-dagger done, thanks for the fast responses!

samtstern added a commit to samtstern/FirebaseUI-Android that referenced this pull request Jan 12, 2017
@samtstern
Revert "fix : fix wrong colors in AuthUI EditText with NightMode (fir…
48a2fe4 
…ebase#504)"

This reverts commit 97ac613.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@the-dagger @samtstern @harshithdwivedi