Skip to content

Dark mode fixes #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Dark mode fixes #517

wants to merge 2 commits into from

Conversation

the-dagger
Copy link
Contributor

Fixes #502
screenshot_20170113-005846
screenshot_20170110-023415

@samtstern
Copy link
Contributor

There's still something wrong here. For example look at the check email screen. The label and hint text color are white on my Pixel:
the-dagger-pr

@the-dagger
Copy link
Contributor Author

Hm, that's strange.
I'm using OnePlus 3 on Android 7.0 and it runs fine.
Hold on, I'll test it on an emulator as well

@samtstern samtstern changed the title Version 1.1.0 dev Dark mode fixes Jan 12, 2017
@samtstern
Copy link
Contributor

@the-dagger did you ever figure this out, or should we close this PR for now?

@the-dagger
Copy link
Contributor Author

the-dagger commented Jan 24, 2017 via email

@samtstern
Copy link
Contributor

@the-dagger it's been over a month since either of us updated this PR so I am going to close it in the name of housekeeping. Please feel free to comment/re-open in the future if you ever come back to it!

@samtstern samtstern closed this Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants