Add firebase repository to README #582
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an instruction to include the fabric repository to app/build.gradle in README.md.
SUPERCILEX
reviewed
Feb 15, 2017
| @@ -41,6 +41,18 @@ dependencies { | |||
| } | |||
| ``` | |||
|
|
|||
| and add the Fabric repository | |||
There was a problem hiding this comment.
@marceloslacerda I agree that this needs to be in the main README because it's part of the installation process, but I think it would be better to link to the sub README like so:
If you're including the `firebase-ui-auth` dependency, there's a little [more setup](https://github.com/firebase/FirebaseUI-Android/tree/master/auth#configuration) required.
There was a problem hiding this comment.
I think your approach is better. Also I am wondering if we should drop the prominent reference to the combined firebase-ui target which causes more problems than it solves.
Merged
|
Pulled this into #604 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an instruction to include the fabric repository to app/build.gradle in README.md.
This have been discussed in #392 and was added to FirebaseUI-Android/auth/README.md but not to FirebaseUI-Android/README.md