Skip to content

Add firebase repository to README #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add firebase repository to README #582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ dependency on the appropriate Firebase SDK so there is no need to include
those separately in your app.

In your `app/build.gradle` file add a dependency on one of the FirebaseUI
libraries.
libraries:

```groovy
dependencies {
Expand All @@ -41,6 +41,18 @@ dependencies {
}
```

and add the Fabric repository
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marceloslacerda I agree that this needs to be in the main README because it's part of the installation process, but I think it would be better to link to the sub README like so:

If you're including the `firebase-ui-auth` dependency, there's a little [more setup](https://github.com/firebase/FirebaseUI-Android/tree/master/auth#configuration) required.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your approach is better. Also I am wondering if we should drop the prominent reference to the combined firebase-ui target which causes more problems than it solves.


```groovy
allprojects {
repositories {
// ...
maven { url 'https://maven.fabric.io/public' }
}
}
```


After the project is synchronized, we're ready to start using Firebase functionality in our app.

### Compatibility with Firebase / Google Play Services Libraries
Expand Down