Style refactor #784
Merged
Style refactor #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUPERCILEX
commented
Jul 2, 2017
| * The view helps display TOS linking to the provided custom URI. | ||
| * It handles the styling of the link and opens the uri in a CustomTabs on click. | ||
| */ | ||
| public class TermsTextView extends AppCompatTextView { |
There was a problem hiding this comment.
This is the only non-style change, I got rid of the custom TextView.
Signed-off-by: Alex Saveau <[email protected]>
samtstern
approved these changes
Jul 5, 2017
| }, SHORT_DELAY_MILLIS); | ||
| } | ||
| }).addOnFailureListener(this, new OnFailureListener() { | ||
| }).addOnFailureListener(this, new OnFailureListener() { | ||
| @Override |
There was a problem hiding this comment.
nit: this indentation is strange, the onFailure method is to the left of addOnFailureListener
| @@ -134,7 +134,7 @@ public void onSaveInstanceState(Bundle outState) { | |||
|
|
|||
| private void setTimer(long millisUntilFinished) { | |||
| mCountDownTextView.setText(String.format(getString(R.string.resend_code_in), | |||
| timeRoundedToSeconds(millisUntilFinished))); | |||
| timeRoundedToSeconds(millisUntilFinished))); | |||
There was a problem hiding this comment.
If this was auto-formatted, can we change the rules not to do these aligned hanging indents (here and everywhere)? They don't survive refactoring.
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
|
@samtstern Done with a green build! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samtstern I started working on making my anonymous auth PR support phone auth, but I kept shuddering some really gross phone auth code so this PR fixes that messiness. 😄
The PR