-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Auth instances cleanup #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth instances cleanup #786
Conversation
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
…nstances-cleanup # Conflicts: # auth/src/main/java/com/firebase/ui/auth/provider/FacebookProvider.java # auth/src/main/java/com/firebase/ui/auth/provider/TwitterProvider.java # auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailFragment.java # auth/src/main/java/com/firebase/ui/auth/ui/phone/CustomCountDownTimer.java # auth/src/main/java/com/firebase/ui/auth/ui/phone/PhoneVerificationActivity.java
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
This change strikes me as a little strange. We've avoided, until now, keeping If we do this change, then we'd have a mixed approach. A more consistent thing to do would be to make this change and then add a |
Signed-off-by: Alex Saveau <[email protected]>
@samtstern Yeah, upon looking back at this PR it does seem kinda gross. I've updated it to convert the |
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
@samtstern Well that was rough. Finally got the build to pass though! 😄 |
Signed-off-by: Alex Saveau <[email protected]>
Sorry I forgot about this, I am fine with this change! |
@samtstern awesome possum! 😀 |
@samtstern While working on the anonymous auth PR, it was frustrating to have to pass in flow params each time I wanted to get an auth or user instance. This PR fixes that issue with a slightly hacky solution of storing the flow params in a static variable that's reset each time the helper activity is created.
This PR is built on top of #785 which is built on top of #784.