Skip to content

Migrate FAC code #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 6, 2021
Merged

Migrate FAC code #1245

merged 5 commits into from
May 6, 2021

Conversation

lahirumaramba
Copy link
Member

No description provided.

lahirumaramba and others added 4 commits April 30, 2021 11:42
* Refactor Crypto Signer

* Introduce new CryptoSignerError type

* reorder imports

* PR fixes

* PR clean up
* Implement the App Check API
* Add AppCheck public API

* Add AppCheck public api unit tests
* (feat): Add FAC Verify token API

- Re-try with all the keys when kid is not present in the token header.
- Add JWKS key fetcher
- Add public API for FAC verify token

* Add ref docs and unit tests

* PR fixes

* Update api extractor report

* Add more tests for token-verifier

* export jwks key pairs

* PR fixes

* More PR fixes

* Update src/app-check/index.ts

Co-authored-by: Kevin Cheung <[email protected]>

Co-authored-by: Kevin Cheung <[email protected]>
@lahirumaramba lahirumaramba requested a review from hiranya911 May 3, 2021 19:08
@lahirumaramba lahirumaramba added the release:stage Stage a release candidate label May 3, 2021
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

@lahirumaramba lahirumaramba merged commit d2330d2 into lm-fac May 6, 2021
@lahirumaramba lahirumaramba deleted the lm-merge-fac branch May 6, 2021 17:53
lahirumaramba added a commit that referenced this pull request May 10, 2021
* Refactor CryptoSigner (#21)

* Refactor Crypto Signer

* Introduce new CryptoSignerError type

* reorder imports

* PR fixes

* PR clean up

* feat(fac): Implement the App Check API (#22)

* Implement the App Check API

* Add AppCheck public API (#23)

* Add AppCheck public API

* Add AppCheck public api unit tests

* Add FAC Verify Token API (#26)

* (feat): Add FAC Verify token API

- Re-try with all the keys when kid is not present in the token header.
- Add JWKS key fetcher
- Add public API for FAC verify token

* Add ref docs and unit tests

* PR fixes

* Update api extractor report

* Add more tests for token-verifier

* export jwks key pairs

* PR fixes

* More PR fixes

* Update src/app-check/index.ts

Co-authored-by: Kevin Cheung <[email protected]>

Co-authored-by: Kevin Cheung <[email protected]>

* Add App ID

Co-authored-by: Kevin Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:stage Stage a release candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants