Making it possible to run integration tests against any Firebase project #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/integration/utils.js
Outdated
| } | ||
|
|
||
| var apiKey = process.argv[2]; | ||
| if (apiKey == undefined) { |
There was a problem hiding this comment.
typeof apiKey === 'undefined'
test/integration/utils.js
Outdated
| return serviceAccount.project_id; | ||
| } | ||
|
|
||
| function getApiKey() { |
There was a problem hiding this comment.
nit: add javadoc for this function like you did for the ones above.
jshcrowthe
reviewed
May 11, 2017
There was a problem hiding this comment.
Changes seem pretty straightforward. I'd address @bojeil-google's comments then this LGTM.
On a side note, with the hardcoded API key here being removed, is there any concern over that project being discovered and used maliciously?
|
Thanks for the reviews. I've made the suggested changes. As @bojeil-google mentioned, it seems there's no risk in exposing the API key. See http://stackoverflow.com/questions/37482366/is-it-safe-to-expose-firebase-apikey-to-the-public for more details. |
bojeil-google
approved these changes
May 11, 2017
lahirumaramba
added a commit
that referenced
this pull request
May 3, 2021
* Implement the App Check API
lahirumaramba
added a commit
that referenced
this pull request
May 6, 2021
* Refactor CryptoSigner (#21) * Refactor Crypto Signer * Introduce new CryptoSignerError type * reorder imports * PR fixes * PR clean up * feat(fac): Implement the App Check API (#22) * Implement the App Check API * Add AppCheck public API (#23) * Add AppCheck public API * Add AppCheck public api unit tests * Add FAC Verify Token API (#26) * (feat): Add FAC Verify token API - Re-try with all the keys when kid is not present in the token header. - Add JWKS key fetcher - Add public API for FAC verify token * Add ref docs and unit tests * PR fixes * Update api extractor report * Add more tests for token-verifier * export jwks key pairs * PR fixes * More PR fixes * Update src/app-check/index.ts Co-authored-by: Kevin Cheung <[email protected]> Co-authored-by: Kevin Cheung <[email protected]> * Add App ID Co-authored-by: Kevin Cheung <[email protected]>
lahirumaramba
added a commit
that referenced
this pull request
May 10, 2021
* Refactor CryptoSigner (#21) * Refactor Crypto Signer * Introduce new CryptoSignerError type * reorder imports * PR fixes * PR clean up * feat(fac): Implement the App Check API (#22) * Implement the App Check API * Add AppCheck public API (#23) * Add AppCheck public API * Add AppCheck public api unit tests * Add FAC Verify Token API (#26) * (feat): Add FAC Verify token API - Re-try with all the keys when kid is not present in the token header. - Add JWKS key fetcher - Add public API for FAC verify token * Add ref docs and unit tests * PR fixes * Update api extractor report * Add more tests for token-verifier * export jwks key pairs * PR fixes * More PR fixes * Update src/app-check/index.ts Co-authored-by: Kevin Cheung <[email protected]> Co-authored-by: Kevin Cheung <[email protected]> * Add App ID Co-authored-by: Kevin Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently integration tests are run against a specific Firebase project (admin-sdks-integration). This enables running integration tests against any Firebase project. This will allow external developers to run the test suite against their own projects/credentials.
See issue: #21