Skip to content

[Auth] Remove AuthErrorCodes '.dynamicLinkNotActivated' & '.invalidDynamicLinkDomain' #15042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2025

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jun 24, 2025

I would think these error cases should be unreachable once FDL is turned down.

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be ok to delete these, since they should be impossible to get with FDL being unavailable.

@ncooke3 ncooke3 self-assigned this Jun 25, 2025
@ncooke3 ncooke3 changed the title [Auth] Deprecate Auth error cases related to FDL [Auth] Remove Auth error cases related to FDL Jun 25, 2025
@ncooke3 ncooke3 changed the title [Auth] Remove Auth error cases related to FDL [Auth] Remove AuthErrorCodes '.dynamicLinkNotActivated' & '.invalidDynamicLinkDomain' Jun 25, 2025
@ncooke3 ncooke3 removed their assignment Jun 25, 2025
@ncooke3 ncooke3 enabled auto-merge (squash) June 25, 2025 14:24
@ncooke3 ncooke3 disabled auto-merge June 25, 2025 14:24
@ncooke3 ncooke3 requested a review from paulb777 June 25, 2025 14:24
@ncooke3 ncooke3 merged commit a9503fd into main Jun 25, 2025
58 checks passed
@ncooke3 ncooke3 deleted the nc/deprecate-case branch June 25, 2025 14:47
cherylEnkidu pushed a commit that referenced this pull request Jun 30, 2025
@firebase firebase locked and limited conversation to collaborators Jul 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants