Skip to content

[Auth] Remove AuthErrorCodes '.dynamicLinkNotActivated' & '.invalidDynamicLinkDomain' #15042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2025
Merged

[Auth] Remove AuthErrorCodes '.dynamicLinkNotActivated' & '.invalidDynamicLinkDomain' #15042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
07c43aa
[Auth] Deprecate Auth error cases related to FDL
ncooke3 Jun 24, 2025
267624f
changelog
ncooke3 Jun 24, 2025
e9c7cd5
Review
ncooke3 Jun 25, 2025
d118347
space
ncooke3 Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions FirebaseAuth/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# Unreleased
- [removed] **Breaking Change**: Removed
`ActionCodeSettings.dynamicLinkDomain`.
- [removed] **Breaking Change**: Removed the following Dynamic Links related
APIs:
- `ActionCodeSettings.dynamicLinkDomain`
- `AuthErrorCode.dynamicLinkNotActivated`
- `AuthErrorCode.invalidDynamicLinkDomain`
- [removed] **Breaking Change**: Remove deprecated Swift APIs using
`String`-typed `productID`s that were in favor of API that leverages the
`AuthProviderID` enum. Note, this only affects Swift clients.
Expand Down
4 changes: 0 additions & 4 deletions FirebaseAuth/Sources/Swift/Utilities/AuthErrorUtils.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,10 +366,6 @@ class AuthErrorUtils {
error(code: .invalidProviderID, message: message)
}

static func invalidDynamicLinkDomainError(message: String?) -> Error {
error(code: .invalidDynamicLinkDomain, message: message)
}

static func invalidHostingLinkDomainError(message: String?) -> Error {
error(code: .invalidHostingLinkDomain, message: message)
}
Expand Down
15 changes: 0 additions & 15 deletions FirebaseAuth/Sources/Swift/Utilities/AuthErrors.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,9 +240,6 @@ import Foundation
/// user was provided.
case nullUser = 17067

/// Indicates that a Firebase Dynamic Link is not activated.
case dynamicLinkNotActivated = 17068

/// Represents the error code for when the given provider id for a web operation is invalid.
case invalidProviderID = 17071

Expand All @@ -254,10 +251,6 @@ import Foundation
/// ID for an operation that does not support multi-tenancy.
case unsupportedTenantOperation = 17073

/// Indicates that the Firebase Dynamic Link domain used is either not configured or is
/// unauthorized for the current project.
case invalidDynamicLinkDomain = 17074

/// Indicates that the provided Firebase Hosting Link domain is not owned by the current project.
case invalidHostingLinkDomain = 17214

Expand Down Expand Up @@ -469,8 +462,6 @@ import Foundation
return kErrorNullUser
case .invalidProviderID:
return kErrorInvalidProviderID
case .invalidDynamicLinkDomain:
return kErrorInvalidDynamicLinkDomain
case .invalidHostingLinkDomain:
return kErrorInvalidHostingLinkDomain
case .webInternalError:
Expand Down Expand Up @@ -505,8 +496,6 @@ import Foundation
return FIRAuthErrorMessageUnsupportedFirstFactor
case .emailChangeNeedsVerification:
return FIRAuthErrorMessageEmailChangeNeedsVerification
case .dynamicLinkNotActivated:
return kErrorDynamicLinkNotActivated
case .rejectedCredential:
return kErrorRejectedCredential
case .missingOrInvalidNonce:
Expand Down Expand Up @@ -664,8 +653,6 @@ import Foundation
return "ERROR_NULL_USER"
case .invalidProviderID:
return "ERROR_INVALID_PROVIDER_ID"
case .invalidDynamicLinkDomain:
return "ERROR_INVALID_DYNAMIC_LINK_DOMAIN"
case .invalidHostingLinkDomain:
return "ERROR_INVALID_HOSTING_LINK_DOMAIN"
case .webInternalError:
Expand Down Expand Up @@ -700,8 +687,6 @@ import Foundation
return "ERROR_UNSUPPORTED_FIRST_FACTOR"
case .emailChangeNeedsVerification:
return "ERROR_EMAIL_CHANGE_NEEDS_VERIFICATION"
case .dynamicLinkNotActivated:
return "ERROR_DYNAMIC_LINK_NOT_ACTIVATED"
case .rejectedCredential:
return "ERROR_REJECTED_CREDENTIAL"
case .missingOrInvalidNonce:
Expand Down
2 changes: 0 additions & 2 deletions FirebaseAuth/Tests/Unit/ObjCAPITests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,11 +275,9 @@ - (void)FIRAuthErrors_h {
c = FIRAuthErrorCodeWebSignInUserInteractionFailure;
c = FIRAuthErrorCodeLocalPlayerNotAuthenticated;
c = FIRAuthErrorCodeNullUser;
c = FIRAuthErrorCodeDynamicLinkNotActivated;
c = FIRAuthErrorCodeInvalidProviderID;
c = FIRAuthErrorCodeTenantIDMismatch;
c = FIRAuthErrorCodeUnsupportedTenantOperation;
c = FIRAuthErrorCodeInvalidDynamicLinkDomain;
c = FIRAuthErrorCodeInvalidHostingLinkDomain;
c = FIRAuthErrorCodeRejectedCredential;
c = FIRAuthErrorCodeGameKitNotLinked;
Expand Down
2 changes: 0 additions & 2 deletions FirebaseAuth/Tests/Unit/SwiftAPI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,11 +273,9 @@ class AuthAPI_hOnlyTests: XCTestCase {
_ = AuthErrorCode.webSignInUserInteractionFailure
_ = AuthErrorCode.localPlayerNotAuthenticated
_ = AuthErrorCode.nullUser
_ = AuthErrorCode.dynamicLinkNotActivated
_ = AuthErrorCode.invalidProviderID
_ = AuthErrorCode.tenantIDMismatch
_ = AuthErrorCode.unsupportedTenantOperation
_ = AuthErrorCode.invalidDynamicLinkDomain
_ = AuthErrorCode.invalidHostingLinkDomain
_ = AuthErrorCode.rejectedCredential
_ = AuthErrorCode.gameKitNotLinked
Expand Down
Loading