Skip to content

Fix a signed/unsigned comparison #7639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2021
Merged

Fix a signed/unsigned comparison #7639

merged 1 commit into from
Mar 2, 2021

Conversation

var-const
Copy link
Contributor

@var-const var-const commented Mar 2, 2021 •
edited
Loading

This triggers a warning in newer versions of GCC and causes compilation to fail with -Werror.

#no-changelog

@var-const var-const requested a review from dconeybe March 2, 2021 20:06
@google-cla google-cla bot added the cla: yes label Mar 2, 2021
@dconeybe dconeybe assigned var-const and unassigned dconeybe Mar 2, 2021
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@vimanyu vimanyu mentioned this pull request Mar 2, 2021
Closed
@google-oss-bot
Copy link

Coverage Report

Affected SDKs

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    SDK overall coverage changed from 88.68% (2f21a7f) to 88.72% (f774221) by +0.04%.

    Filename Base (2f21a7f) Head (f774221) Diff
    leveldb_key.cc 96.96% 96.48% -0.48%
    leveldb_persistence.cc 89.60% 89.71% +0.12%
    serializer.cc 83.68% 84.40% +0.72%
    watch_stream.cc 92.31% 96.15% +3.85%

Test Logs

@var-const var-const merged commit 5f6feba into master Mar 2, 2021
@var-const var-const deleted the varconst/fix-signedness branch March 2, 2021 20:51
@firebase firebase locked and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@var-const var-const

Labels
api: firestore cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@var-const @google-oss-bot @dconeybe