Skip to content

comparing uint to uint. #7640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vimanyu
Copy link
Contributor

@vimanyu vimanyu commented Mar 2, 2021

Fixes compiler errors after github ubuntu runners were upgraded to 20 from 18 and gcc from 10.1.0 to 10.2.0.

build/external/src/firestore/Firestore/core/src/local/leveldb_persistence.cc:199:36: error: comparison of integer expressions of different signedness: ‘uint64_t’ {aka ‘long unsigned int’} and ‘long int’ [-Werror=sign-compare]
2021-03-01T23:04:48.9071111Z   199 |     if (count < old_count || count > std::numeric_limits<int64_t>::max()) {
2021-03-01T23:04:48.9071795Z       |                              ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2021-03-01T23:04:48.9072445Z cc1plus: all warnings being treated as errors

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in a feature request so that we
    can discuss it together.

Seeing errors on linux after github ubuntu runners were upgraded
to 20 from 18 and gcc from 10.1.0 to 10.2.0.
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@vimanyu vimanyu closed this Mar 2, 2021
@vimanyu
Copy link
Contributor Author

vimanyu commented Mar 2, 2021

Fix is already being pushed in another PR.
#7639

@vimanyu vimanyu deleted the bugfix/compiler-error-different-signedness branch March 2, 2021 20:11
@google-oss-bot
Copy link

Coverage Report

Affected SDKs

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    SDK overall coverage changed from 88.68% (2f21a7f) to 88.67% (fe85ff2) by -0.00%.

    Filename Base (2f21a7f) Head (fe85ff2) Diff
    leveldb_key.cc 96.96% 96.48% -0.48%
    task.cc 95.21% 96.41% +1.20%

Test Logs

@firebase firebase locked and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants