BundleSerializer changes for Protobuf migration #7999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
force-pushed
the
mrschmidt/bundleserializer
branch
from
ce5fcb5 to
759187f
Compare
Generated by 🚫 Danger |
wu-hui
approved these changes
Apr 28, 2021
| @@ -522,13 +526,13 @@ BundledQuery BundleSerializer::DecodeBundledQuery( | |||
|
|
|||
| auto start_at_bound = DecodeBound(reader, structured_query, "startAt"); | |||
| std::shared_ptr<Bound> start_at; | |||
| if (!start_at_bound.position().empty()) { | |||
| if (start_at_bound.position().values_count) { | |||
There was a problem hiding this comment.
Hmm, it is probably just me, but i always found adding a > 0 helps readability..optional.
|
|
||
| return rpc_serializer_.DecodeReference(&reader, ref_string); | ||
| google_firestore_v1_ArrayValue array_value{}; | ||
| SetRepeatedField(&array_value.values, &array_value.values_count, values, |
There was a problem hiding this comment.
I think the behavior changed..there was an early exit if decoding a value failed. But maybe it does not matter..if there is no easy way to bring that back, I am OK to leave it as it is now.
There was a problem hiding this comment.
It not as easy anymore to do the validation since I am generally just passing through the protos. I could handle bundles differently, but for now I prefer to keep the current handling (and show a warning in DocumentSnapshot.data())
schmidt-sebastian
force-pushed
the
mrschmidt/bundleserializer
branch
from
40321d2 to
c6a9340
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #7904. It will break the feature branch, but I am planning to send out small reviewable chunks with an end goal of a feature branch that passes CI.
This PR changes the Bundle serializer to serialize into NanoPB.