Skip to content

Use Protobuf-backed FieldValues #7904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 51 commits into from

Conversation

schmidt-sebastian
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in a feature request so that we
    can discuss it together.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@schmidt-sebastian schmidt-sebastian changed the title Mrschmidt/migrate Use Protobuf-backed FieldValues Apr 20, 2021
@google-oss-bot
Copy link

Coverage Report

Affected SDKs

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    SDK overall coverage changed from 88.48% (697902b) to 88.47% (c8591a2) by -0.01%.

    Click to show coverage changes in 40 files.
    Filename Base (697902b) Head (c8591a2) Diff
    FIRDocumentSnapshot.mm 89.84% 97.96% +8.12%
    FIRFirestore.mm 91.63% 91.61% -0.02%
    FIRQuery.mm 88.39% 88.56% +0.17%
    FIRTransaction.mm 97.71% 97.67% -0.04%
    FSTUserDataReader.mm ? 95.16% ?
    FSTUserDataWriter.mm ? 82.35% ?
    bound.cc 82.46% 81.36% -1.10%
    bundle_serializer.cc 92.62% 93.22% +0.60%
    byte_string.cc 84.85% 80.30% -4.55%
    database_id.cc 71.43% 67.86% -3.57%
    delete_mutation.cc 85.29% 90.32% +5.03%
    document_key.cc 94.64% 95.31% +0.67%
    document_set.cc 88.57% 88.41% -0.17%
    field_filter.cc 90.00% 89.31% -0.69%
    firestore_client.cc 99.16% 99.15% -0.01%
    geo_point.cc 85.00% 65.00% -20.00%
    leveldb_key.cc 96.79% 97.96% +1.17%
    leveldb_migrations.cc 100.00% 93.40% -6.60%
    local_serializer.cc 90.83% 92.38% +1.55%
    local_store.cc 99.50% 100.00% +0.50%
    mutable_document.cc ? 60.00% ?
    mutation.cc 88.62% 85.11% -3.51%
    mutation_batch.cc 90.59% 89.74% -0.84%
    object_value.cc ? 97.52% ?
    patch_mutation.cc 93.02% 89.66% -3.37%
    precondition.cc 70.73% 69.23% -1.50%
    query_engine.cc 96.70% 96.67% -0.04%
    query_snapshot.cc 84.26% 84.40% +0.14%
    remote_event.cc 97.35% 97.34% -0.02%
    remote_objc_bridge.cc 91.36% 91.30% -0.05%
    serializer.cc 83.96% 83.60% -0.37%
    server_timestamp_util.cc ? 98.75% ?
    set_mutation.cc 85.19% 84.31% -0.87%
    snapshot_version.cc 83.33% 66.67% -16.67%
    sync_engine.cc 94.86% 94.85% -0.01%
    timestamp_internal.cc 89.19% 64.86% -24.32%
    transform_operation.cc 73.56% 77.45% +3.89%
    value_util.cc ? 89.31% ?
    view.cc 98.47% 98.42% -0.04%
    write_stream.cc 93.48% 95.65% +2.17%

Test Logs

@schmidt-sebastian schmidt-sebastian changed the base branch from mrschmidt/mutabledocuments to master May 5, 2021 20:43
@schmidt-sebastian schmidt-sebastian changed the base branch from master to mrschmidt/mutabledocuments May 5, 2021 20:44
@firebase firebase locked and limited conversation to collaborators Jun 18, 2021
@paulb777 paulb777 deleted the mrschmidt/migrate branch September 2, 2022 22:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants