Skip to content

Test Refactor for Protobuf-backed FieldValue #8003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2021
Merged

Test Refactor for Protobuf-backed FieldValue #8003

merged 2 commits into from
May 4, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Apr 28, 2021 •
edited
Loading

This is part of #7904. It will break the feature branch, but I am planning to send out small reviewable chunks with an end goal of a feature branch that passes CI.

This PR contains the test files that only have "mechanical refactor" changes.

  • No more DocumentState. Instead we use SetHasLocalMutations/SetHasCommittedMutations. `
  • No more MaybeDocument. Instead we now have MutableDocument.
  • No more MaybeDocumentMap. Instead just DocumentMap.
  • A Document is now a const wrapper on top of MutableDocument. Hence, some callsites change to ->

@google-cla google-cla bot added the cla: yes label Apr 28, 2021
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

thebrianchen
thebrianchen approved these changes May 4, 2021
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test changes lgtm

@schmidt-sebastian schmidt-sebastian merged commit d59d753 into mrschmidt/mutabledocuments May 4, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/testonly branch May 4, 2021 17:01
@firebase firebase locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thebrianchen thebrianchen thebrianchen approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @thebrianchen