Skip to content

TestUtil methods that create Protobuf #8008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2021
Merged

TestUtil methods that create Protobuf #8008

merged 2 commits into from
May 13, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

These are the test util changes of the larger migration PR (#7904)

@google-cla google-cla bot added the cla: yes label Apr 29, 2021
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@schmidt-sebastian
Copy link
Contributor Author

@wu-hui Do you have time to take a look at this?

wu-hui
wu-hui approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui May 13, 2021
@schmidt-sebastian schmidt-sebastian merged commit 20d6893 into mrschmidt/mutabledocuments May 13, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/testutil branch May 13, 2021 15:36
@firebase firebase locked and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @wu-hui